status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Fixed `accessibilityLabel` implementation in RCTParagraphComponentView 

Summary: The code fragment `super.accessibilityLabel` always meant "use stored value which came from Props". But after we override the implementation of this getter in the base class, this starts working differently (wrong). This change basically reverts that to original intent.

Reviewed By: sahrens

Differential Revision: D10350597

fbshipit-source-id: 913951eb08c4ede76fc0e9be76b48d86599bcc62
This commit is contained in:
Valentin Shergin 2018-10-15 23:23:35 -07:00 committed by Facebook Github Bot
parent 278023470f
commit d73254b441
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
View File

@ -77,7 +77,8 @@ using namespace facebook::react;
- (NSString *)accessibilityLabel
{
NSString *superAccessibilityLabel = [super accessibilityLabel];
NSString *superAccessibilityLabel =
RCTNSStringFromStringNilIfEmpty(_props->accessibilityLabel);
if (superAccessibilityLabel) {
return superAccessibilityLabel;
}