status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-27 00:20:31 +00:00
Code Issues Projects Releases Wiki Activity

Avoid app crashing when a StackOverflowError is thrown when rendering deep RN view hierarcy

Browse Source 
Reviewed By: achen1

Differential Revision: D7400906

fbshipit-source-id: faaf701a88440f89390518f00e6a35f19e9203db
This commit is contained in:
David Vacca 2018-03-31 23:20:52 -07:00 committed by Facebook Github Bot
parent 4906f8d28c
commit d58ba8242b
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java
View File

@ -21,6 +21,7 @@ import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.view.animation.Animation; import android.view.animation.Animation;
import com.facebook.infer.annotation.Assertions; import com.facebook.infer.annotation.Assertions;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.common.annotations.VisibleForTesting; import com.facebook.react.common.annotations.VisibleForTesting;
import com.facebook.react.modules.i18nmanager.I18nUtil; import com.facebook.react.modules.i18nmanager.I18nUtil;
import com.facebook.react.touch.OnInterceptTouchEventListener; import com.facebook.react.touch.OnInterceptTouchEventListener;
@ -668,7 +669,12 @@ public class ReactViewGroup extends ViewGroup implements
if (rootView != null) { if (rootView != null) {
rootView.handleException(e); rootView.handleException(e);
} else { } else {
throw e; if (getContext() instanceof ReactContext) {
ReactContext reactContext = (ReactContext) getContext();
reactContext.handleException(new IllegalViewOperationException("StackOverflowException", this, e));
} else {
throw e;
}
} }
} }
} }