mirror of
https://github.com/status-im/react-native.git
synced 2025-01-14 19:44:13 +00:00
add host argument for packager.
Summary: Now packager only listen to "::", which is IPv6 "Any address". It failed to run in IPv4 Environment. defaults to undefined or empty string will fix this. And I think it's necessary to let user define host by cli argument. It's also for security reason. When working on a public network, it's much safer to listen with localhost instead of ::, which may let everyone in same network be able to get your code from debugger-ui. recommit for #1918, fixes #2441 Closes https://github.com/facebook/react-native/pull/5377 Reviewed By: svcscm Differential Revision: D2842594 Pulled By: martinbigio fb-gh-sync-id: 575944c5469dac80e99136a7903ea99f5339dba1
This commit is contained in:
parent
4f37fe6f68
commit
d4f6e447d2
@ -44,7 +44,7 @@ function runServer(args, config, readyCallback) {
|
|||||||
|
|
||||||
const serverInstance = http.createServer(app).listen(
|
const serverInstance = http.createServer(app).listen(
|
||||||
args.port,
|
args.port,
|
||||||
'::',
|
args.host,
|
||||||
function() {
|
function() {
|
||||||
attachHMRServer({
|
attachHMRServer({
|
||||||
httpServer: serverInstance,
|
httpServer: serverInstance,
|
||||||
|
@ -30,6 +30,10 @@ function _server(argv, config, resolve, reject) {
|
|||||||
command: 'port',
|
command: 'port',
|
||||||
default: 8081,
|
default: 8081,
|
||||||
type: 'string',
|
type: 'string',
|
||||||
|
}, {
|
||||||
|
command: 'host',
|
||||||
|
default: '',
|
||||||
|
type: 'string',
|
||||||
}, {
|
}, {
|
||||||
command: 'root',
|
command: 'root',
|
||||||
type: 'string',
|
type: 'string',
|
||||||
|
Loading…
x
Reference in New Issue
Block a user