status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-14 11:34:23 +00:00
Code Issues Projects Releases Wiki Activity

Properly validate layout animation config

Browse Source 
Summary:
The type key for a layout animation config must be supplied otherwise the app crashes (on Android). I added a isRequired check in JS as well as an explicit exception in java otherwise it crashed at a very hard to debug place. The crash happens when passing null to `Animation.setInterpolator` so this makes sure it never happens.

**Test plan (required)**

Tested that the error is caught properly in JS when passing an invalid animation config like

```
LayoutAnimation.configureNext({
  duration: 250,
   update: { type: undefined }, // or LayoutAnimation.Types.easeInEastOut in my case haha :)
});
```

Also tested the java exception.
Closes https://github.com/facebook/react-native/pull/7958

Differential Revision: D3401760

Pulled By: nicklockwood

fbshipit-source-id: 83c019d863c2b2294405b60e87297c562add0f49
This commit is contained in:
Janic Duplessis 2016-06-07 16:22:56 -07:00 committed by Facebook Github Bot 5
parent 0e50373b60
commit d4e7c8a055
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LayoutAnimation/LayoutAnimation.js
View File

@ -40,7 +40,7 @@ var animChecker = createStrictShapeTypeChecker({
initialVelocity: PropTypes.number,
type: PropTypes.oneOf(
Object.keys(Types)
),
).isRequired,
property: PropTypes.oneOf( // Only applies to create/delete
Object.keys(Properties)
),

6
ReactAndroid/src/main/java/com/facebook/react/uimanager/layoutanimation/AbstractLayoutAnimation.java
View File

@ -61,8 +61,10 @@ import com.facebook.react.uimanager.IllegalViewOperationException;
AnimatedPropertyType.fromString(data.getString("property")) : null;
mDurationMs = data.hasKey("duration") ? data.getInt("duration") : globalDuration;
mDelayMs = data.hasKey("delay") ? data.getInt("delay") : 0;
mInterpolator = data.hasKey("type") ?
getInterpolator(InterpolatorType.fromString(data.getString("type"))) : null;
if (!data.hasKey("type")) {
throw new IllegalArgumentException("Missing interpolation type.");
}
mInterpolator = getInterpolator(InterpolatorType.fromString(data.getString("type")));
if (!isValid()) {
throw new IllegalViewOperationException("Invalid layout animation : " + data);