status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-26 16:10:58 +00:00
Code Issues Projects Releases Wiki Activity

Bikeshedding in ReactTextInputShadowNode, part 2

Browse Source 
Reviewed By: AaaChiuuu

Differential Revision: D5712962

fbshipit-source-id: b0cb5dbbd93b661252e5ddcf6c0a34e59cb7f2c6
This commit is contained in:
Valentin Shergin 2017-09-06 17:08:34 -07:00 committed by Facebook Github Bot
parent 5f1f0b14f0
commit d2f3a7282b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java
View File

@ -43,7 +43,7 @@ public class ReactTextInputShadowNode extends ReactTextShadowNode implements
YogaMeasureFunction { YogaMeasureFunction {
private @Nullable EditText mEditText; private @Nullable EditText mEditText;
private int mJsEventCount = UNSET; private int mMostRecentEventCount = UNSET;
public ReactTextInputShadowNode() { public ReactTextInputShadowNode() {
mTextBreakStrategy = (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) ? mTextBreakStrategy = (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) ?
@ -111,7 +111,7 @@ public class ReactTextInputShadowNode extends ReactTextShadowNode implements
@ReactProp(name = "mostRecentEventCount") @ReactProp(name = "mostRecentEventCount")
public void setMostRecentEventCount(int mostRecentEventCount) { public void setMostRecentEventCount(int mostRecentEventCount) {
mJsEventCount = mostRecentEventCount; mMostRecentEventCount = mostRecentEventCount;
} }
@Override @Override
@ -135,12 +135,12 @@ public class ReactTextInputShadowNode extends ReactTextShadowNode implements
public void onCollectExtraUpdates(UIViewOperationQueue uiViewOperationQueue) { public void onCollectExtraUpdates(UIViewOperationQueue uiViewOperationQueue) {
super.onCollectExtraUpdates(uiViewOperationQueue); super.onCollectExtraUpdates(uiViewOperationQueue);
if (mJsEventCount != UNSET) { if (mMostRecentEventCount != UNSET) {
Spannable preparedSpannableText = spannedFromShadowNode(this); Spannable preparedSpannableText = spannedFromShadowNode(this);
ReactTextUpdate reactTextUpdate = ReactTextUpdate reactTextUpdate =
new ReactTextUpdate( new ReactTextUpdate(
preparedSpannableText, preparedSpannableText,
mJsEventCount, mMostRecentEventCount,
mContainsImages, mContainsImages,
getPadding(Spacing.LEFT), getPadding(Spacing.LEFT),
getPadding(Spacing.TOP), getPadding(Spacing.TOP),