status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-28 02:04:55 +00:00
Code Issues Projects Releases Wiki Activity

Debug only code were leaking into release builds on iOS. (#21232)

Browse Source 
Summary:
RCT_DEBUG is always defined - it is just rather 0 or 1 so
```#ifndef RCT_DEBUG is always true```
Pull Request resolved: https://github.com/facebook/react-native/pull/21232

Differential Revision: D9982316

Pulled By: hramos

fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
This commit is contained in:
Sergei Dryganets 2018-09-20 17:35:41 -07:00 committed by Facebook Github Bot
parent 40bcc38d91
commit d1ff0b0cc5
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
React/Base/RCTUtils.m
View File

@ -810,7 +810,7 @@ static void RCTGetRGBAColorComponents(CGColorRef color, CGFloat rgba[4])
default:
{
#ifdef RCT_DEBUG
#if RCT_DEBUG
//unsupported format
RCTLogError(@"Unsupported color model: %i", model);
#endif

2
React/CxxBridge/RCTCxxBridge.mm
View File

@ -654,7 +654,7 @@ struct RCTInstanceCallback : public InstanceCallback {
NSArray<RCTModuleData *> *moduleDataById = [self registerModulesForClasses:modules];
if (lazilyDiscovered) {
#ifdef RCT_DEBUG
#if RCT_DEBUG
// Lazily discovered modules do not require instantiation here,
// as they are not allowed to have pre-instantiated instance
// and must not require the main queue.