status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-28 09:00:55 +00:00
Code Issues Projects Releases Wiki Activity

Finalize many of FlatShadowNode methods

Browse Source 
Summary: These methods (mostly getters/setters) are not meant to be overriden, so let's make them final. Hopefully, they will inline better, too.

Reviewed By: ahmedre

Differential Revision: D2933869
This commit is contained in:
Denis Koroskin 2016-02-16 17:24:14 -08:00 committed by Ahmed El-Helw
parent 99d95d8168
commit d1ccb6d23d
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java
View File

@ -100,7 +100,7 @@ import com.facebook.react.uimanager.ViewProps;
} }
@ReactProp(name = "overflow") @ReactProp(name = "overflow")
public void setOverflow(String overflow) { public final void setOverflow(String overflow) {
mClipToBounds = "hidden".equals(overflow); mClipToBounds = "hidden".equals(overflow);
invalidate(); invalidate();
} }
@ -141,7 +141,7 @@ import com.facebook.react.uimanager.ViewProps;
/** /**
* Returns an array of DrawCommands to perform during the View's draw pass. * Returns an array of DrawCommands to perform during the View's draw pass.
*/ */
/* package */ DrawCommand[] getDrawCommands() { /* package */ final DrawCommand[] getDrawCommands() {
return mDrawCommands; return mDrawCommands;
} }
@ -149,7 +149,7 @@ import com.facebook.react.uimanager.ViewProps;
* Sets an array of DrawCommands to perform during the View's draw pass. StateBuilder uses old * Sets an array of DrawCommands to perform during the View's draw pass. StateBuilder uses old
* draw commands to compare to new draw commands and see if the View neds to be redrawn. * draw commands to compare to new draw commands and see if the View neds to be redrawn.
*/ */
/* package */ void setDrawCommands(DrawCommand[] drawCommands) { /* package */ final void setDrawCommands(DrawCommand[] drawCommands) {
mDrawCommands = drawCommands; mDrawCommands = drawCommands;
} }
@ -157,14 +157,14 @@ import com.facebook.react.uimanager.ViewProps;
* Sets an array of AttachDetachListeners to call onAttach/onDetach when they are attached to or * Sets an array of AttachDetachListeners to call onAttach/onDetach when they are attached to or
* detached from a View that this shadow node maps to. * detached from a View that this shadow node maps to.
*/ */
/* package */ void setAttachDetachListeners(AttachDetachListener[] listeners) { /* package */ final void setAttachDetachListeners(AttachDetachListener[] listeners) {
mAttachDetachListeners = listeners; mAttachDetachListeners = listeners;
} }
/** /**
* Returns an array of AttachDetachListeners associated with this shadow node. * Returns an array of AttachDetachListeners associated with this shadow node.
*/ */
/* package */ AttachDetachListener[] getAttachDetachListeners() { /* package */ final AttachDetachListener[] getAttachDetachListeners() {
return mAttachDetachListeners; return mAttachDetachListeners;
} }
@ -218,7 +218,7 @@ import com.facebook.react.uimanager.ViewProps;
/** /**
* Sets boundaries of the View that this node maps to relative to the parent left/top coordinate. * Sets boundaries of the View that this node maps to relative to the parent left/top coordinate.
*/ */
/* package */ void setViewBounds(int left, int top, int right, int bottom) { /* package */ final void setViewBounds(int left, int top, int right, int bottom) {
mViewLeft = left; mViewLeft = left;
mViewTop = top; mViewTop = top;
mViewRight = right; mViewRight = right;
@ -228,28 +228,28 @@ import com.facebook.react.uimanager.ViewProps;
/** /**
* Left position of the View this node maps to relative to the parent View. * Left position of the View this node maps to relative to the parent View.
*/ */
/* package */ int getViewLeft() { /* package */ final int getViewLeft() {
return mViewLeft; return mViewLeft;
} }
/** /**
* Top position of the View this node maps to relative to the parent View. * Top position of the View this node maps to relative to the parent View.
*/ */
/* package */ int getViewTop() { /* package */ final int getViewTop() {
return mViewTop; return mViewTop;
} }
/** /**
* Right position of the View this node maps to relative to the parent View. * Right position of the View this node maps to relative to the parent View.
*/ */
/* package */ int getViewRight() { /* package */ final int getViewRight() {
return mViewRight; return mViewRight;
} }
/** /**
* Bottom position of the View this node maps to relative to the parent View. * Bottom position of the View this node maps to relative to the parent View.
*/ */
/* package */ int getViewBottom() { /* package */ final int getViewBottom() {
return mViewBottom; return mViewBottom;
} }