status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

[Images] Bail out when GIF data is in unexpected format instead of crashing 

Summary:
When the GIF data is not a string nor NSData, `imageSource` is some unknown value set to whatever memory was on the stack. Calling `CGImageSourceGetType` on it has undefined behavior, and if it makes through to the CFRelease (maybe because it is NULL) then CFRelease will crash. This fixes a clang warning.
Closes https://github.com/facebook/react-native/pull/77
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
This commit is contained in:
James Ide 2015-02-26 07:20:36 -08:00
parent 96312af117
commit d0d774d403
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactKit/Base/RCTConvert.m
View File

@ -446,6 +446,9 @@ RCT_STRUCT_CONVERTER(CGAffineTransform, (@[@"a", @"b", @"c", @"d", @"tx", @"ty"]
} }
imageSource = CGImageSourceCreateWithData((CFDataRef)data, NULL); imageSource = CGImageSourceCreateWithData((CFDataRef)data, NULL);
} else {
RCTLogMustFix(@"Expected NSString or NSData for GIF, received %@: %@", [json class], json);
return nil;
} }
if (!UTTypeConformsTo(CGImageSourceGetType(imageSource), kUTTypeGIF)) { if (!UTTypeConformsTo(CGImageSourceGetType(imageSource), kUTTypeGIF)) {