From ce7de93275c3f51fc06a2533f69a57bb85f4f1ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Oghin=C4=83?= Date: Thu, 22 Oct 2015 14:25:03 +0100 Subject: [PATCH] [android] remove deprecated gradle plugin --- react-native-gradle/.gitignore | 5 - .../.idea/codeStyleSettings.xml | 110 --------- react-native-gradle/README.md | 68 ----- react-native-gradle/build.gradle | 18 -- react-native-gradle/settings.gradle | 1 - .../facebook/react/AbstractPackageJsTask.java | 232 ------------------ .../facebook/react/PackageDebugJsTask.java | 20 -- .../facebook/react/PackageReleaseJsTask.java | 20 -- .../com/facebook/react/PackagerParams.java | 96 -------- .../facebook/react/ReactGradleExtension.java | 95 ------- .../com/facebook/react/ReactGradlePlugin.java | 39 --- .../com.facebook.react.properties | 1 - .../facebook/react/PackageJSTasksTest.java | 85 ------- .../facebook/react/ReactGradlePluginTest.java | 26 -- 14 files changed, 816 deletions(-) delete mode 100644 react-native-gradle/.gitignore delete mode 100644 react-native-gradle/.idea/codeStyleSettings.xml delete mode 100644 react-native-gradle/README.md delete mode 100644 react-native-gradle/build.gradle delete mode 100644 react-native-gradle/settings.gradle delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/AbstractPackageJsTask.java delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/PackageDebugJsTask.java delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/PackageReleaseJsTask.java delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/PackagerParams.java delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/ReactGradleExtension.java delete mode 100644 react-native-gradle/src/main/java/com/facebook/react/ReactGradlePlugin.java delete mode 100644 react-native-gradle/src/main/resources/META-INF/gradle-plugins/com.facebook.react.properties delete mode 100644 react-native-gradle/src/test/java/com/facebook/react/PackageJSTasksTest.java delete mode 100644 react-native-gradle/src/test/java/com/facebook/react/ReactGradlePluginTest.java diff --git a/react-native-gradle/.gitignore b/react-native-gradle/.gitignore deleted file mode 100644 index fb4e414c7..000000000 --- a/react-native-gradle/.gitignore +++ /dev/null @@ -1,5 +0,0 @@ -.idea/* -!.idea/codeStyleSettings.xml - -.gradle -*.iml diff --git a/react-native-gradle/.idea/codeStyleSettings.xml b/react-native-gradle/.idea/codeStyleSettings.xml deleted file mode 100644 index 3932f5c0c..000000000 --- a/react-native-gradle/.idea/codeStyleSettings.xml +++ /dev/null @@ -1,110 +0,0 @@ - - - - - - - diff --git a/react-native-gradle/README.md b/react-native-gradle/README.md deleted file mode 100644 index 6b74a62b7..000000000 --- a/react-native-gradle/README.md +++ /dev/null @@ -1,68 +0,0 @@ -# React Native Gradle plugin - -This is a plugin for the default build system for Android applications, [gradle][0]. It hooks into the default Android build lifecycle and copies the JS bundle from the packager server to the `assets/` folder. - -## Usage - -To add this plugin to an existing Android project, first add this to your top-level `build.gradle` file, under `buildscript / dependencies`: - - classpath 'com.facebook.react:gradleplugin:1.0.+' - -Then apply the plugin to your application module (usually `app/build.gradle`): - - apply plugin: 'com.facebook.react' - -That's it! The plugin will now download the bundle from the default packager location (http://localhost:8081/index.android.js) and place it in the assets folder at build time. - -## Configuration - -The following shows all of the values that can be customized and their defaults. Configuration goes into your application module (`app/build.gradle`). - - react { - bundleFileName "index.android.bundle" - bundlePath "/index.android.bundle" - jsRoot "../../" - packagerHost "localhost:8082" - packagerCommand "../node_modules/react-native/packager/launchAndroidPackager.command" - - devParams { - dev true - inlineSourceMap false - minify false - runModule true - skip true - } - releaseParams { - dev false - inlineSourceMap false - minify true - runModule true - skip false - } - } - -Here's a breakdown of the various configurations: - -* `bundleFileName` specifies the name of the asset file that is generated and bundled in the `.apk` -* `bundlePath` is the path to the bundle, as recognized by the packager server -* `jsRoot` is the root of your entire app; this is scanned for `.js` files to determine when the bundle needs to be re-fetched -* `packagerHost` is the packager server address -* `packagerCommand` specifies how to start the packager server if it's not running -* `devParams` and `releaseParams` specify what parameters to include in the request to the packager server when fetching the bundle; see below for more information -* `skip` in `devParams` and `releaseParams` specifies whether to skip requesting and bundling the JS for that configuration - -The default config makes it so that the following bundles are added to the respective builds, as `assets/index.android.bundle`. The dev bundle is normally skipped as it is loaded from the packager at runtime, but you can change this behavior by setting `skip` to `false` under `devParams`: - -| Build | Packager URL | -|---------|---------------------------------------------------------------------------------------------------| -| dev | http://localhost:8082/index.android.js?dev=true&inlineSourceMap=false&minify=false&runModule=true | -| release | http://localhost:8082/index.android.js?dev=false&inlineSourceMap=false&minify=true&runModule=true | - -For more information regarding the URL parameters, check out the [packager documentation][1]. - -## Contributing - -After you make changes to the plugin code, simply run `gradle build install` in this directory. Then, in your Android project, change the top-level buildscript classpath dependency to whatever version you just built, something like `1.2.3-SNAPSHOT`. This should be picked up and used from your local maven repository. - -[0]: https://gradle.org/ -[1]: https://github.com/facebook/react-native/blob/master/packager/README.md diff --git a/react-native-gradle/build.gradle b/react-native-gradle/build.gradle deleted file mode 100644 index 0c3d1c9fa..000000000 --- a/react-native-gradle/build.gradle +++ /dev/null @@ -1,18 +0,0 @@ -group = 'com.facebook.react' -version = '1.0.0-SNAPSHOT' - -apply plugin: 'groovy' -apply plugin: 'maven' - -repositories { - mavenCentral() -} - -dependencies { - compile gradleApi() - compile 'commons-io:commons-io:2.4' - compile 'org.apache.commons:commons-lang3:3.4' - - testCompile 'junit:junit:4.12' - testCompile 'com.squareup.okhttp:mockwebserver:2.4.0' -} \ No newline at end of file diff --git a/react-native-gradle/settings.gradle b/react-native-gradle/settings.gradle deleted file mode 100644 index e20229db8..000000000 --- a/react-native-gradle/settings.gradle +++ /dev/null @@ -1 +0,0 @@ -rootProject.name = 'gradleplugin' \ No newline at end of file diff --git a/react-native-gradle/src/main/java/com/facebook/react/AbstractPackageJsTask.java b/react-native-gradle/src/main/java/com/facebook/react/AbstractPackageJsTask.java deleted file mode 100644 index d9c0c400b..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/AbstractPackageJsTask.java +++ /dev/null @@ -1,232 +0,0 @@ -package com.facebook.react; - -import java.io.File; -import java.io.FileOutputStream; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.net.HttpURLConnection; -import java.net.MalformedURLException; -import java.net.URI; -import java.net.URISyntaxException; -import java.net.URL; -import java.nio.file.FileSystems; -import java.nio.file.FileVisitResult; -import java.nio.file.Files; -import java.nio.file.Path; -import java.nio.file.PathMatcher; -import java.nio.file.Paths; -import java.nio.file.SimpleFileVisitor; -import java.nio.file.attribute.BasicFileAttributes; - -import org.apache.commons.io.FilenameUtils; -import org.apache.commons.io.IOUtils; -import org.apache.commons.lang3.SystemUtils; -import org.gradle.api.DefaultTask; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -/** - * Base class for tasks that build JS packages. Handles requesting a bundle from the packager server - * and putting it into the appropriate folder. - */ -public abstract class AbstractPackageJsTask extends DefaultTask { - - /** - * Describes the status of the JS packager server. - * - * @see #getPackagerStatus - */ - private enum PackagerStatus { - /** - * Packager is up and running - */ - RUNNING, - - /** - * Packager is not running, but could be started - */ - NOT_RUNNING, - - /** - * Packager is not running and can't be started, something else is listening on the configured - * port - */ - UNKNOWN - } - - private final boolean mDebug; - private final ReactGradleExtension mConfig; - private final PackagerParams mPackagerParams; - - private final Logger mLogger = LoggerFactory.getLogger(getClass()); - - public AbstractPackageJsTask(boolean debug) throws IOException { - mDebug = debug; - - mConfig = ReactGradleExtension.getConfig(getProject()); - mPackagerParams = PackagerParams.getPackagerParams(mConfig, mDebug); - - if (mPackagerParams.isSkip()) { - setEnabled(false); - } else { - setupInputs(mConfig); - setupOutputs(mConfig); - } - } - - /** - * Get a bundle from packager and copy it to the appropriate folder. - */ - protected void copyBundle() throws Exception { - File bundle = getOutputFile(mConfig); - bundle.getParentFile().mkdirs(); - - PackagerStatus packagerStatus = getPackagerStatus(mConfig); - if (packagerStatus == PackagerStatus.NOT_RUNNING) { - boolean started = startPackager(); - if (started) { - packagerStatus = getPackagerStatus(mConfig); - } - if (!started || packagerStatus != PackagerStatus.RUNNING) { - throw new Exception( - "Could not start packager server. Please start it manually and try again."); - } - } - if (packagerStatus == PackagerStatus.RUNNING) { - URL packageUrl = getPackageUrl(mConfig, mPackagerParams); - - InputStream packageStream = packageUrl.openStream(); - OutputStream bundleStream = new FileOutputStream(bundle); - IOUtils.copy(packageStream, bundleStream); - IOUtils.closeQuietly(packageStream); - IOUtils.closeQuietly(bundleStream); - } else if (packagerStatus == PackagerStatus.UNKNOWN) { - throw new Exception( - "Did not recognize the server at " + mConfig.getPackagerHost() + - ". Please stop the service listening at this address and try again."); - } - } - - /** - * Tests if there is an HTTP server running at the configured address and if it is our packager. - * See {@link PackagerStatus} for the possible return values and their meaning. - * - * @param config the project config that contains packager address information - */ - private PackagerStatus getPackagerStatus(ReactGradleExtension config) throws URISyntaxException { - try { - URL statusUrl = new URI("http", config.getPackagerHost(), "/status", null, null).toURL(); - HttpURLConnection conn = (HttpURLConnection) statusUrl.openConnection(); - if (conn.getResponseCode() != 200) { - // something else must be running on this port - return PackagerStatus.UNKNOWN; - } - InputStream is = conn.getInputStream(); - String status = IOUtils.toString(is); - IOUtils.closeQuietly(is); - return status.contains("packager-status:running") - ? PackagerStatus.RUNNING - : PackagerStatus.UNKNOWN; - } catch (IOException e) { - // connect must have failed - return PackagerStatus.NOT_RUNNING; - } - } - - /** - * Tries to spawn a process to run the packager server. Currently support OSX and Linux by running - * {@code open launchPackager.command} and {@code xterm -e bash launchPackager.command} - * respectively. Always waits 5 seconds for the server to finish initializing. - * - * @return {@code true} if the server process was started successfully, {@code false} otherwise. - */ - private boolean startPackager() throws IOException, InterruptedException { - if (SystemUtils.IS_OS_MAC_OSX || SystemUtils.IS_OS_LINUX) { - String launchPackagerScript = - Paths.get(getProject().getProjectDir().getAbsolutePath(), mConfig.getPackagerCommand()) - .normalize().toString(); - if (SystemUtils.IS_OS_MAC_OSX) { - Runtime.getRuntime().exec(new String[]{"open", launchPackagerScript}, null, null); - } else if (SystemUtils.IS_OS_LINUX) { - Runtime.getRuntime() - .exec(new String[]{"xterm", "-e", "bash", launchPackagerScript}, null, null); - } - // wait for server to be ready - Thread.sleep(5000); - return true; - } - return false; - } - - /** - * Generate a packager URL for a specific configuration. - * - * @param config the top-level config of the plugin - * @param params packager params to include in the URL - */ - private URL getPackageUrl(ReactGradleExtension config, PackagerParams params) - throws URISyntaxException, MalformedURLException { - String query = "dev=" + params.isDev() + "&" + - "inlineSourceMap=" + params.isInlineSourceMap() + "&" + - "minify=" + params.isMinify() + "&" + - "runModule=" + params.isRunModule(); - return new URI( - "http", - config.getPackagerHost(), - config.getBundlePath(), - query, - null).toURL(); - } - - private void setupInputs(ReactGradleExtension config) throws IOException { - final long startTime = System.currentTimeMillis(); - InputsScanner scanner = new InputsScanner(); - Files.walkFileTree( - Paths.get(getProject().getProjectDir().getAbsolutePath(), config.getJsRoot()).normalize(), - scanner); - final long endTime = System.currentTimeMillis(); - mLogger.info("Added {} .js files in {}ms", scanner.getCount(), endTime - startTime); - } - - private void setupOutputs(ReactGradleExtension config) { - getOutputs().file(getOutputFile(config)); - } - - private File getOutputFile(ReactGradleExtension config) { - File assets = new File( - getProject().getProjectDir(), - FilenameUtils - .separatorsToSystem("build/intermediates/assets/" + (mDebug ? "debug" : "release"))); - return new File(assets, config.getBundleFileName()); - } - - private class InputsScanner extends SimpleFileVisitor { - - private final PathMatcher mMatcher = FileSystems.getDefault().getPathMatcher("glob:*.js"); - private int mCount = 0; - - @Override - public FileVisitResult preVisitDirectory( - Path dir, BasicFileAttributes attrs) throws IOException { - if ("build".equals(dir.getFileName().toString())) { - return FileVisitResult.SKIP_SUBTREE; - } else { - return FileVisitResult.CONTINUE; - } - } - - @Override - public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException { - if (mMatcher.matches(file.getFileName())) { - getInputs().file(file.toString()); - mCount++; - } - return FileVisitResult.CONTINUE; - } - - public int getCount() { - return mCount; - } - } -} diff --git a/react-native-gradle/src/main/java/com/facebook/react/PackageDebugJsTask.java b/react-native-gradle/src/main/java/com/facebook/react/PackageDebugJsTask.java deleted file mode 100644 index 97a1dba29..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/PackageDebugJsTask.java +++ /dev/null @@ -1,20 +0,0 @@ -package com.facebook.react; - -import java.io.IOException; - -import org.gradle.api.tasks.TaskAction; - -/** - * Gradle task that copies the dev bundle to the debug build's assets. - */ -public class PackageDebugJsTask extends AbstractPackageJsTask { - - public PackageDebugJsTask() throws IOException { - super(true); - } - - @TaskAction - public void packageJS() throws Exception { - copyBundle(); - } -} diff --git a/react-native-gradle/src/main/java/com/facebook/react/PackageReleaseJsTask.java b/react-native-gradle/src/main/java/com/facebook/react/PackageReleaseJsTask.java deleted file mode 100644 index 932f07d30..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/PackageReleaseJsTask.java +++ /dev/null @@ -1,20 +0,0 @@ -package com.facebook.react; - -import java.io.IOException; - -import org.gradle.api.tasks.TaskAction; - -/** - * Gradle task that copies the prod bundle to the debug build's assets. - */ -public class PackageReleaseJsTask extends AbstractPackageJsTask { - - public PackageReleaseJsTask() throws IOException { - super(false); - } - - @TaskAction - public void packageJS() throws Exception { - copyBundle(); - } -} diff --git a/react-native-gradle/src/main/java/com/facebook/react/PackagerParams.java b/react-native-gradle/src/main/java/com/facebook/react/PackagerParams.java deleted file mode 100644 index 2e0f91cde..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/PackagerParams.java +++ /dev/null @@ -1,96 +0,0 @@ -package com.facebook.react; - -/** - * POJO for packager parameters. - */ -public class PackagerParams { - private boolean dev = true; - private boolean inlineSourceMap = false; - private boolean minify = false; - private boolean runModule = true; - private boolean skip = false; - - /** - * Returns default parameters for debug builds. - */ - public static PackagerParams devDefaults() { - PackagerParams params = new PackagerParams(); - params.dev = true; - params.inlineSourceMap = false; - params.minify = false; - params.runModule = true; - params.skip = true; - return params; - } - - /** - * Returns default parameters for release builds. - */ - public static PackagerParams releaseDefaults() { - PackagerParams params = new PackagerParams(); - params.dev = false; - params.inlineSourceMap = false; - params.minify = true; - params.runModule = true; - params.skip = false; - return params; - } - - /** - * Extract packager parameters from a configuration, or return default values. - * - * @param config the configuration to extract from - * @param debug whether default values should be for debug or prod - */ - public static PackagerParams getPackagerParams(ReactGradleExtension config, boolean debug) { - if (debug) { - return config.getDevParams() != null - ? config.getDevParams() - : PackagerParams.devDefaults(); - } else { - return config.getReleaseParams() != null - ? config.getReleaseParams() - : PackagerParams.releaseDefaults(); - } - } - - public boolean isDev() { - return dev; - } - - public void dev(boolean dev) { - this.dev = dev; - } - - public boolean isInlineSourceMap() { - return inlineSourceMap; - } - - public void inlineSourceMap(boolean inlineSourceMap) { - this.inlineSourceMap = inlineSourceMap; - } - - public boolean isMinify() { - return minify; - } - - public void minify(boolean minify) { - this.minify = minify; - } - - public boolean isRunModule() { - return runModule; - } - - public void runModule(boolean runModule) { - this.runModule = runModule; - } - - public boolean isSkip() { - return skip; - } - - public void skip(boolean skip) { - this.skip = skip; - } -} diff --git a/react-native-gradle/src/main/java/com/facebook/react/ReactGradleExtension.java b/react-native-gradle/src/main/java/com/facebook/react/ReactGradleExtension.java deleted file mode 100644 index e7b8d1624..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/ReactGradleExtension.java +++ /dev/null @@ -1,95 +0,0 @@ -package com.facebook.react; - -import groovy.lang.Closure; -import org.gradle.api.Project; - -/** - * POJO-ish class for configuring the plugin. - */ -public class ReactGradleExtension { - private String bundleFileName = "index.android.bundle"; - private String bundlePath = "/index.android.bundle"; - private String jsRoot = "../../"; - private String packagerHost = "localhost:8082"; - private String packagerCommand = - "../../node_modules/react-native/packager/launchAndroidPackager.command"; - - private PackagerParams devParams; - private PackagerParams releaseParams; - - private Project project; - - public ReactGradleExtension(Project project) { - this.project = project; - } - - /** - * Get the configuration for a project, or a blank config. - */ - public static ReactGradleExtension getConfig(Project project) { - ReactGradleExtension config = - project.getExtensions().findByType(ReactGradleExtension.class); - if (config == null) { - config = new ReactGradleExtension(project); - } - return config; - } - - public String getBundleFileName() { - return bundleFileName; - } - - public void setBundleFileName(String bundleFileName) { - this.bundleFileName = bundleFileName; - } - - public String getBundlePath() { - return bundlePath; - } - - public void setBundlePath(String bundlePath) { - this.bundlePath = bundlePath; - } - - public String getJsRoot() { - return jsRoot; - } - - public void setJsRoot(String jsRoot) { - this.jsRoot = jsRoot; - } - - public void setPackagerCommand(String packagerCommand) { - this.packagerCommand = packagerCommand; - } - - public String getPackagerCommand() { - return packagerCommand; - } - - public String getPackagerHost() { - return packagerHost; - } - - public void setPackagerHost(String packagerHost) { - this.packagerHost = packagerHost; - } - - public PackagerParams getDevParams() { - return devParams; - } - - public void devParams(Closure closure) { - devParams = new PackagerParams(); - project.configure(devParams, closure); - } - - public PackagerParams getReleaseParams() { - return releaseParams; - } - - public void releaseParams(Closure closure) { - releaseParams = new PackagerParams(); - project.configure(releaseParams, closure); - } -} diff --git a/react-native-gradle/src/main/java/com/facebook/react/ReactGradlePlugin.java b/react-native-gradle/src/main/java/com/facebook/react/ReactGradlePlugin.java deleted file mode 100644 index d1fd917ba..000000000 --- a/react-native-gradle/src/main/java/com/facebook/react/ReactGradlePlugin.java +++ /dev/null @@ -1,39 +0,0 @@ -package com.facebook.react; - -import org.gradle.api.Action; -import org.gradle.api.Plugin; -import org.gradle.api.Project; -import org.gradle.api.Task; - -/** - * Main entry point for our plugin. When applied to a project, this registers the {@code react} - * gradle extension used for configuration and the {@code packageDebugJS} and - * {@code packageReleaseJS} tasks. These are set up to run after {@code mergeDebugAssets} and - * {@code mergeReleaseAssets} and before {@code processDebugResources} and - * {@code processReleaseResources} respectively. If any of these tasks are not found the plugin will - * crash (UnknownTaskException), as it was probably applied to a non-standard Android project, or it - * was applied incorrectly. - */ -public class ReactGradlePlugin implements Plugin { - @Override - public void apply(Project project) { - project.getExtensions().create("react", ReactGradleExtension.class, project); - - project.afterEvaluate( - new Action() { - @Override - public void execute(Project project) { - PackageDebugJsTask packageDebugJsTask = - project.getTasks().create("packageDebugJS", PackageDebugJsTask.class); - PackageReleaseJsTask packageReleaseJsTask = - project.getTasks().create("packageReleaseJS", PackageReleaseJsTask.class); - - packageDebugJsTask.dependsOn("mergeDebugAssets"); - project.getTasks().getByName("processDebugResources").dependsOn(packageDebugJsTask); - - packageReleaseJsTask.dependsOn("mergeReleaseAssets"); - project.getTasks().getByName("processReleaseResources").dependsOn(packageReleaseJsTask); - } - }); - } -} diff --git a/react-native-gradle/src/main/resources/META-INF/gradle-plugins/com.facebook.react.properties b/react-native-gradle/src/main/resources/META-INF/gradle-plugins/com.facebook.react.properties deleted file mode 100644 index a70934715..000000000 --- a/react-native-gradle/src/main/resources/META-INF/gradle-plugins/com.facebook.react.properties +++ /dev/null @@ -1 +0,0 @@ -implementation-class=com.facebook.react.ReactGradlePlugin diff --git a/react-native-gradle/src/test/java/com/facebook/react/PackageJSTasksTest.java b/react-native-gradle/src/test/java/com/facebook/react/PackageJSTasksTest.java deleted file mode 100644 index 45ecc8782..000000000 --- a/react-native-gradle/src/test/java/com/facebook/react/PackageJSTasksTest.java +++ /dev/null @@ -1,85 +0,0 @@ -package com.facebook.react; - -import java.io.File; -import java.io.IOException; -import java.net.URISyntaxException; - -import com.squareup.okhttp.mockwebserver.MockResponse; -import com.squareup.okhttp.mockwebserver.MockWebServer; -import com.squareup.okhttp.mockwebserver.RecordedRequest; -import org.apache.commons.io.FileUtils; -import org.apache.commons.io.FilenameUtils; -import org.gradle.api.Action; -import org.gradle.api.Project; -import org.gradle.api.Task; -import org.gradle.testfixtures.ProjectBuilder; -import org.junit.Before; -import org.junit.Test; - -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertTrue; - -public class PackageJSTasksTest { - - private MockWebServer server; - private Project project; - - @Before - public void setupMocks() throws IOException { - server = new MockWebServer(); - server.enqueue(new MockResponse().setBody("This is some javascript")); - server.start(); - - project = ProjectBuilder.builder().build(); - project.getPlugins().apply("com.facebook.react"); - project.getExtensions().configure( - ReactGradleExtension.class, - new Action() { - @Override - public void execute(ReactGradleExtension config) { - config.setPackagerHost(server.getHostName() + ":" + server.getPort()); - config.setBundleFileName("test.js"); - config.setBundlePath("/test.bundle"); - } - }); - } - - @Test - public void packageDebugJS() throws IOException, URISyntaxException, InterruptedException { - Task task = project.getTasks().findByName("packageDebugJS"); - assertTrue(task != null && task instanceof PackageDebugJsTask); - - ((PackageDebugJsTask) task).packageJS(); - - RecordedRequest request = server.takeRequest(); - assertEquals( - "/test.bundle?dev=true&inlineSourceMap=false&minify=false&runModule=true", - request.getPath()); - assertEquals( - "This is some javascript", - FileUtils.readFileToString( - new File( - project.getProjectDir(), - FilenameUtils.separatorsToSystem("build/intermediates/assets/debug/test.js")))); - } - - @Test - public void packageReleaseJS() throws IOException, URISyntaxException, InterruptedException { - Task task = project.getTasks().findByName("packageReleaseJS"); - assertTrue(task != null && task instanceof PackageReleaseJsTask); - - ((PackageReleaseJsTask) task).packageJS(); - - RecordedRequest request = server.takeRequest(); - assertEquals( - "/test.bundle?dev=false&inlineSourceMap=false&minify=true&runModule=true", - request.getPath()); - assertEquals( - "This is some javascript", - FileUtils.readFileToString( - new File( - project.getProjectDir(), - FilenameUtils.separatorsToSystem("build/intermediates/assets/release/test.js")))); - } - -} diff --git a/react-native-gradle/src/test/java/com/facebook/react/ReactGradlePluginTest.java b/react-native-gradle/src/test/java/com/facebook/react/ReactGradlePluginTest.java deleted file mode 100644 index 85ddb13a3..000000000 --- a/react-native-gradle/src/test/java/com/facebook/react/ReactGradlePluginTest.java +++ /dev/null @@ -1,26 +0,0 @@ -package com.facebook.react; - -import org.gradle.api.Project; -import org.gradle.testfixtures.ProjectBuilder; -import org.junit.Test; - -import static org.junit.Assert.assertTrue; - -public class ReactGradlePluginTest { - @Test - public void addsTasksToProject() { - Project project = ProjectBuilder.builder().build(); - project.getPlugins().apply("com.facebook.react"); - - assertTrue(project.getTasks().getByName("packageDebugJS") instanceof PackageDebugJsTask); - assertTrue(project.getTasks().getByName("packageReleaseJS") instanceof PackageReleaseJsTask); - } - - @Test - public void addsExtensionToProject() { - Project project = ProjectBuilder.builder().build(); - project.getPlugins().apply("com.facebook.react"); - - assertTrue(project.getExtensions().getByName("react") instanceof ReactGradleExtension); - } -}