status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-28 10:14:49 +00:00
Code Issues Projects Releases Wiki Activity

Only handle accessibility notifications from the correct RCTAccessibilityManager

Browse Source 
Summary: When you reload and create a new bridge, one of the things that happens during setup is that the RCTAccessibilityManager fires a notification. The old bridge would receive this notification from the new bridge's RCTAccessibilityManager, which we don't want, especially because the two are running on different shadow queues.

I believe this led to a gnarly crash in NSConcreteTextStorage because RCTMeasure in RCTShadowText.m was getting called for the old RCTText (getting destroyed) from a notification fired from the new shadow queue. The fix is for the UIManager to handle notifications only from its bridge's RCTAccessibilityManager. See #2001 for the kinds of crashes we were seeing.
Closes https://github.com/facebook/react-native/pull/3279

Reviewed By: @​svcscm

Differential Revision: D2521652

Pulled By: @nicklockwood

fb-gh-sync-id: a4ffe3ef8304667727e573e2a2e8b716e1d2f3e1
This commit is contained in:
James Ide 2015-10-08 03:47:43 -07:00 committed by facebook-github-bot-9
parent 34c26f31f6
commit cb8b656a82
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
React/Modules/RCTUIManager.m
View File

@ -229,20 +229,10 @@ extern NSString *RCTBridgeModuleNameForClass(Class cls);
_rootViewTags = [NSMutableSet new]; _rootViewTags = [NSMutableSet new];
_bridgeTransactionListeners = [NSMutableSet new]; _bridgeTransactionListeners = [NSMutableSet new];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(didReceiveNewContentSizeMultiplier)
name:RCTAccessibilityManagerDidUpdateMultiplierNotification
object:nil];
} }
return self; return self;
} }
- (void)dealloc
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
}
- (void)didReceiveNewContentSizeMultiplier - (void)didReceiveNewContentSizeMultiplier
{ {
__weak RCTUIManager *weakSelf = self; __weak RCTUIManager *weakSelf = self;
@ -276,6 +266,8 @@ extern NSString *RCTBridgeModuleNameForClass(Class cls);
[_pendingUIBlocksLock lock]; [_pendingUIBlocksLock lock];
_pendingUIBlocks = nil; _pendingUIBlocks = nil;
[_pendingUIBlocksLock unlock]; [_pendingUIBlocksLock unlock];
[[NSNotificationCenter defaultCenter] removeObserver:self];
}); });
} }
@ -296,6 +288,11 @@ extern NSString *RCTBridgeModuleNameForClass(Class cls);
} }
_componentDataByName = [componentDataByName copy]; _componentDataByName = [componentDataByName copy];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(didReceiveNewContentSizeMultiplier)
name:RCTAccessibilityManagerDidUpdateMultiplierNotification
object:_bridge.accessibilityManager];
} }
- (dispatch_queue_t)methodQueue - (dispatch_queue_t)methodQueue