status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-28 10:14:49 +00:00
Code Issues Projects Releases Wiki Activity

Add viewConfig to RCTSlider Component, fix #10158

Browse Source 
Summary:
And check componet.viewConfig before call component.setNativeProps method.

FIX #10158
Closes https://github.com/facebook/react-native/pull/10238

Differential Revision: D4008640

Pulled By: javache

fbshipit-source-id: 1bf9b34c0e56f1ffbcd31ae64b3cbafe77a9a1fd
This commit is contained in:
leeight 2016-10-12 08:46:22 -07:00 committed by Facebook Github Bot
parent 4b7f84aee8
commit c9960817ee
3 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Examples/UIExplorer/js/RTLExample.js
View File

@ -47,8 +47,6 @@ const {
const UIExplorerPage = require('./UIExplorerPage'); const UIExplorerPage = require('./UIExplorerPage');
const UIExplorerBlock = require('./UIExplorerBlock'); const UIExplorerBlock = require('./UIExplorerBlock');
const AnimatedImage = Animated.createAnimatedComponent(Image);
type State = { type State = {
toggleStatus: any, toggleStatus: any,
pan: Object, pan: Object,
@ -116,7 +114,7 @@ function AnimationBlock(props) {
return ( return (
<View style={styles.block}> <View style={styles.block}>
<TouchableWithoutFeedback onPress={props.onPress}> <TouchableWithoutFeedback onPress={props.onPress}>
<AnimatedImage <Animated.Image
style={[styles.img, props.imgStyle]} style={[styles.img, props.imgStyle]}
source={require('./Thumbnails/poke.png')} source={require('./Thumbnails/poke.png')}
/> />

6
Libraries/Animated/src/AnimatedImplementation.js
View File

@ -1715,6 +1715,12 @@ function createAnimatedComponent(Component: any): any {
var callback = () => { var callback = () => {
if (this._component.setNativeProps) { if (this._component.setNativeProps) {
if (!this._propsAnimated.__isNative) { if (!this._propsAnimated.__isNative) {
if (this._component.viewConfig == null) {
var ctor = this._component.constructor;
var componentName = ctor.displayName || ctor.name || '<Unknown Component>';
throw new Error(componentName + ' "viewConfig" is not defined.');
}
this._component.setNativeProps( this._component.setNativeProps(
this._propsAnimated.__getAnimatedValue() this._propsAnimated.__getAnimatedValue()
); );

9
Libraries/Components/Slider/Slider.js
View File

@ -13,6 +13,7 @@
var Image = require('Image'); var Image = require('Image');
var NativeMethodsMixin = require('react/lib/NativeMethodsMixin'); var NativeMethodsMixin = require('react/lib/NativeMethodsMixin');
var ReactNativeViewAttributes = require('ReactNativeViewAttributes');
var Platform = require('Platform'); var Platform = require('Platform');
var PropTypes = require('react/lib/ReactPropTypes'); var PropTypes = require('react/lib/ReactPropTypes');
var React = require('React'); var React = require('React');
@ -139,6 +140,14 @@ var Slider = React.createClass({
}; };
}, },
viewConfig: {
uiViewClassName: 'RCTSlider',
validAttributes: {
...ReactNativeViewAttributes.RCTView,
value: true
}
},
render: function() { render: function() {
const {style, onValueChange, onSlidingComplete, ...props} = this.props; const {style, onValueChange, onSlidingComplete, ...props} = this.props;
props.style = [styles.slider, style]; props.style = [styles.slider, style];