From c68bb6a72c0a63cc26e5cdcfcddf21e270d1de19 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Wed, 30 Aug 2017 03:36:23 -0700 Subject: [PATCH] Update systrace markers Reviewed By: AaaChiuuu Differential Revision: D5707578 fbshipit-source-id: 90afc7c0c7dd66eda621f990ca3a11848adeb4e5 --- ReactCommon/cxxreact/Instance.cpp | 10 +++++----- ReactCommon/cxxreact/ModuleRegistry.cpp | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ReactCommon/cxxreact/Instance.cpp b/ReactCommon/cxxreact/Instance.cpp index 34f54e048..f3329d27c 100644 --- a/ReactCommon/cxxreact/Instance.cpp +++ b/ReactCommon/cxxreact/Instance.cpp @@ -54,7 +54,7 @@ void Instance::loadApplication(std::unique_ptr unbundle, std::unique_ptr string, std::string sourceURL) { callback_->incrementPendingJSCalls(); - SystraceSection s("reactbridge_xplat_loadApplication", "sourceURL", + SystraceSection s("Instance::loadApplication", "sourceURL", sourceURL); nativeToJsBridge_->loadApplication(std::move(unbundle), std::move(string), std::move(sourceURL)); @@ -66,7 +66,7 @@ void Instance::loadApplicationSync(std::unique_ptr unbundle, std::unique_lock lock(m_syncMutex); m_syncCV.wait(lock, [this] { return m_syncReady; }); - SystraceSection s("reactbridge_xplat_loadApplicationSync", "sourceURL", + SystraceSection s("Instance::loadApplicationSync", "sourceURL", sourceURL); nativeToJsBridge_->loadApplicationSync(std::move(unbundle), std::move(string), std::move(sourceURL)); @@ -74,7 +74,7 @@ void Instance::loadApplicationSync(std::unique_ptr unbundle, void Instance::setSourceURL(std::string sourceURL) { callback_->incrementPendingJSCalls(); - SystraceSection s("reactbridge_xplat_setSourceURL", "sourceURL", sourceURL); + SystraceSection s("Instance::setSourceURL", "sourceURL", sourceURL); nativeToJsBridge_->loadApplication(nullptr, nullptr, std::move(sourceURL)); } @@ -82,7 +82,7 @@ void Instance::setSourceURL(std::string sourceURL) { void Instance::loadScriptFromString(std::unique_ptr string, std::string sourceURL, bool loadSynchronously) { - SystraceSection s("reactbridge_xplat_loadScriptFromString", "sourceURL", + SystraceSection s("Instance::loadScriptFromString", "sourceURL", sourceURL); if (loadSynchronously) { loadApplicationSync(nullptr, std::move(string), std::move(sourceURL)); @@ -123,7 +123,7 @@ void Instance::callJSFunction(std::string &&module, std::string &&method, } void Instance::callJSCallback(uint64_t callbackId, folly::dynamic &¶ms) { - SystraceSection s(""); + SystraceSection s("Instance::callJSCallback"); callback_->incrementPendingJSCalls(); nativeToJsBridge_->invokeCallback((double)callbackId, std::move(params)); } diff --git a/ReactCommon/cxxreact/ModuleRegistry.cpp b/ReactCommon/cxxreact/ModuleRegistry.cpp index c91b01afc..8779e7e94 100644 --- a/ReactCommon/cxxreact/ModuleRegistry.cpp +++ b/ReactCommon/cxxreact/ModuleRegistry.cpp @@ -74,7 +74,7 @@ std::vector ModuleRegistry::moduleNames() { } folly::Optional ModuleRegistry::getConfig(const std::string& name) { - SystraceSection s("getConfig", "module", name); + SystraceSection s("ModuleRegistry::getConfig", "module", name); // Initialize modulesByName_ if (modulesByName_.empty() && !modules_.empty()) {