From c5da1068f8fa17f5f10067b744c623f8d696e057 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Wed, 30 Nov 2016 17:47:42 -0800 Subject: [PATCH] Update JDK download link for Mac OS Android set up Summary: *First PR to React Native.* After performing a clean install of macOS Sierra on my machine I tried to get RN set up again and noticed that the link provided for installing Java (required by Android Studio) pointed to the [wrong location](https://www.java.com/en/download/mac_download.jsp). After some time researching I found the right package required by Android Studio [here](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html). I tried looking for a more general link (as this points to the JDK version 8 and has a weird path: _jdk8-downloads-2133151.html_ - Sadly this was the best I could find. I also looked through listed issues to try and find a previous attempt to fix this error but couldn't find any references, sorry if I missed anything. **TL;DR:** JDK download link is incorrect, PR updates it to the correct one. Closes https://github.com/facebook/react-native/pull/11201 Differential Revision: D4253304 Pulled By: hramos fbshipit-source-id: be8ffe059bf60f5d7aa1876e5581b270187864c2 --- docs/GettingStarted.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/GettingStarted.md b/docs/GettingStarted.md index f87a4cb25..7cd9e2a7c 100644 --- a/docs/GettingStarted.md +++ b/docs/GettingStarted.md @@ -160,7 +160,14 @@ Setting up your development environment can be somewhat tedious if you're new to -> Android Studio requires the [Java Development Kit (JDK)](https://www.java.com/en/download/mac_download.jsp), version 1.8 or higher. You can type `javac -version` in a terminal to see what version you have, if any. +> Android Studio requires the [Java SE Development Kit(JDK)](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html), version 8. You can type `javac -version` in a terminal to see what version you have, if any. + +``` +$ javac -version +javac 1.8.0_111 +``` + +> The version string `1.8.x_xxx` corresponds to JDK 8.