status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Inspecting stateless components. 

Summary:
Fixes #4602

Fixes a bug where the app crashes when you try to inspect a stateless
component.
Fixed by replacing all occurrences of the getPublicInstance method in
Libraries/Inspector/Inspector.js with the _instance property instead.
Defaults to an empty object if _instance is falsy.
Closes https://github.com/facebook/react-native/pull/4642

Reviewed By: svcscm

Differential Revision: D2734491

Pulled By: androidtrunkagent

fb-gh-sync-id: 4ea753b7e0ef3fd05af2d80abadc365c5c787f98
This commit is contained in:
Edvin Erikson 2015-12-08 10:09:16 -08:00 committed by facebook-github-bot-4
parent c9d796fc6a
commit c489660f26
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/Inspector/Inspector.js
View File

@ -98,7 +98,9 @@ class Inspector extends React.Component {
setSelection(i: number) { setSelection(i: number) {
var instance = this.state.hierarchy[i]; var instance = this.state.hierarchy[i];
var publicInstance = instance.getPublicInstance(); // if we inspect a stateless component we can't use the getPublicInstance method
// therefore we use the internal _instance property directly.
var publicInstance = instance._instance || {};
UIManager.measure(React.findNodeHandle(instance), (x, y, width, height, left, top) => { UIManager.measure(React.findNodeHandle(instance), (x, y, width, height, left, top) => {
this.setState({ this.setState({
inspected: { inspected: {
@ -115,7 +117,9 @@ class Inspector extends React.Component {
this.state.devtoolsAgent.selectFromReactInstance(instance, true); this.state.devtoolsAgent.selectFromReactInstance(instance, true);
} }
var hierarchy = InspectorUtils.getOwnerHierarchy(instance); var hierarchy = InspectorUtils.getOwnerHierarchy(instance);
var publicInstance = instance.getPublicInstance(); // if we inspect a stateless component we can't use the getPublicInstance method
// therefore we use the internal _instance property directly.
var publicInstance = instance._instance || {};
var props = publicInstance.props || {}; var props = publicInstance.props || {};
this.setState({ this.setState({
panelPos: pointerY > Dimensions.get('window').height / 2 ? 'top' : 'bottom', panelPos: pointerY > Dimensions.get('window').height / 2 ? 'top' : 'bottom',