From c43d8409c01a40648d355063f5ef99ed052f3c18 Mon Sep 17 00:00:00 2001 From: Denis Koroskin Date: Mon, 11 Jan 2016 20:03:23 -0800 Subject: [PATCH] Fix RTCText incorrectly clipping its background Summary: Wrong order or top/right -> right/top means that clipping can be incorrect. I didn't notice it because visual result in many cases would still be the same (especially with overflow: visible being default and clipping being mostly disabled). Also only background was clipped incorrectly, and most texts don't have a background. Reviewed By: ahmedre Differential Revision: D2816432 --- ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java index 20b96e207..aa04b3931 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/RCTText.java @@ -157,8 +157,8 @@ import com.facebook.react.uimanager.ViewProps; right, bottom, clipLeft, - clipRight, clipTop, + clipRight, clipBottom); if (mText == null) {