status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add back deprecated getParent methods for non-breaking API change (#775) 

Summary:
I'm not totally sure what I'm doing so if this needs changes let me know.
Closes https://github.com/facebook/yoga/pull/775

Reviewed By: emilsjolander

Differential Revision: D8331892

Pulled By: passy

fbshipit-source-id: eb1023e666322d2472e4081fd4a4e72a7b43d049
This commit is contained in:
Vince Mi 2018-06-11 04:07:38 -07:00 committed by Facebook Github Bot
parent 4aeefa5484
commit c3c5c3cbce
5 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java
View File

@ -234,15 +234,14 @@ public class YogaNode implements Cloneable {
* {@link YogaNode} is shared between two or more YogaTrees.
*/
@Nullable
public
YogaNode getOwner() {
public YogaNode getOwner() {
return mOwner;
}
/** @deprecated Use #getOwner() instead. This will be removed in the next version. */
@Deprecated
@Nullable
YogaNode getParent() {
public YogaNode getParent() {
return getOwner();
}

4
ReactCommon/yoga/yoga/YGNode.cpp
View File

@ -53,6 +53,10 @@ YGNodeRef YGNode::getOwner() const {
return owner_;
}
YGNodeRef YGNode::getParent() const {
return getOwner();
}
YGVector YGNode::getChildren() const {
return children_;
}

2
ReactCommon/yoga/yoga/YGNode.h
View File

@ -78,6 +78,8 @@ struct YGNode {
// to one YogaTree or nullptr when the YGNode is shared between two or more
// YogaTrees.
YGNodeRef getOwner() const;
// Deprecated, use getOwner() instead.
YGNodeRef getParent() const;
YGVector getChildren() const;
uint32_t getChildrenCount() const;
YGNodeRef getChild(uint32_t index) const;

4
ReactCommon/yoga/yoga/Yoga.cpp
View File

@ -535,6 +535,10 @@ YGNodeRef YGNodeGetOwner(const YGNodeRef node) {
return node->getOwner();
}
YGNodeRef YGNodeGetParent(const YGNodeRef node) {
return node->getOwner();
}
void YGNodeMarkDirty(const YGNodeRef node) {
YGAssertWithNode(
node,

1
ReactCommon/yoga/yoga/Yoga.h
View File

@ -92,6 +92,7 @@ WIN_EXPORT void YGNodeRemoveChild(const YGNodeRef node, const YGNodeRef child);
WIN_EXPORT void YGNodeRemoveAllChildren(const YGNodeRef node);
WIN_EXPORT YGNodeRef YGNodeGetChild(const YGNodeRef node, const uint32_t index);
WIN_EXPORT YGNodeRef YGNodeGetOwner(const YGNodeRef node);
WIN_EXPORT YGNodeRef YGNodeGetParent(const YGNodeRef node);
WIN_EXPORT uint32_t YGNodeGetChildCount(const YGNodeRef node);
WIN_EXPORT void YGNodeSetChildren(
YGNodeRef const owner,