status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use numeric module IDs for iOS RA-bundles 

Summary:Use the new numeric module IDs for indexed-file random access bundles, rather than string-based module names

This still uses those IDs as strings in the table, to make this bundle format work again.

Reviewed By: martinbigio

Differential Revision: D3050337

fb-gh-sync-id: f8da69cdbafd1b093a71474698796be5d21fc4f6
shipit-source-id: f8da69cdbafd1b093a71474698796be5d21fc4f6
This commit is contained in:
David Aurelio 2016-03-14 17:20:18 -07:00 committed by Facebook Github Bot 0
parent 06b5bda349
commit bff0b1f9d6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
local-cli/bundle/output/unbundle/as-indexed-file.js
View File

@ -65,9 +65,9 @@ function writeBuffers(stream, buffers) {
});
}
function moduleToBuffer(name, code, encoding) {
function moduleToBuffer(id, code, encoding) {
return {
name,
id,
linesCount: code.split('\n').length,
buffer: Buffer.concat([
Buffer(code, encoding),
@ -101,10 +101,10 @@ function buildModuleTable(buffers) {
const offsetTable = [tableLengthBuffer];
for (let i = 0; i < numBuffers; i++) {
const {name, linesCount, buffer: {length}} = buffers[i];
const {id, linesCount, buffer: {length}} = buffers[i];
const entry = Buffer.concat([
Buffer(i === 0 ? MAGIC_STARTUP_MODULE_ID : name, 'utf8'),
Buffer(i === 0 ? MAGIC_STARTUP_MODULE_ID : id, 'utf8'),
nullByteBuffer,
uInt32Buffer(currentOffset),
uInt32Buffer(currentLine),
@ -126,7 +126,7 @@ function buildModuleBuffers(startupCode, modules, encoding) {
[moduleToBuffer('', startupCode, encoding, true)].concat(
modules.map(module =>
moduleToBuffer(
module.name,
String(module.id),
module.code + '\n', // each module starts on a newline
encoding,
)