status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make AccessibilityInfo.setAccessibilityFocus cross platform (#20229) 

Summary:
Currently, `AccessibilityInfo.setAccessibilityFocus` is only available on iOS. The same behaviour can be achieved on Android by dispatching the proper accessibility event. I implemented the same function for Android, to make life slightly more convenient for the developer.

Today, developers must write something like this:
```
if (Platform.OS === 'ios') {
     AccessibilityInfo.setAccessibilityFocus(reactTag)
} else {
     UIManager.sendAccessibilityEvent(reactTag, 8)
}
```

With this change, the following is enough for both Android and iOS:
```
AccessibilityInfo.setAccessibilityFocus(reactTag)
```
Pull Request resolved: https://github.com/facebook/react-native/pull/20229

Differential Revision: D8874107

Pulled By: mdvacca

fbshipit-source-id: a6ffd7bb89ce56d6d65b06419633a71dcf3d0733
This commit is contained in:
Mats Byrkeland 2018-07-18 17:13:56 -07:00 committed by Facebook Github Bot
parent 7ff7572e5c
commit be715ec705
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Libraries/Components/AccessibilityInfo/AccessibilityInfo.android.js
View File

@ -12,6 +12,7 @@
const NativeModules = require('NativeModules'); const NativeModules = require('NativeModules');
const RCTDeviceEventEmitter = require('RCTDeviceEventEmitter'); const RCTDeviceEventEmitter = require('RCTDeviceEventEmitter');
const UIManager = require('UIManager');
const RCTAccessibilityInfo = NativeModules.AccessibilityInfo; const RCTAccessibilityInfo = NativeModules.AccessibilityInfo;
@ -66,6 +67,18 @@ const AccessibilityInfo = {
listener.remove(); listener.remove();
_subscriptions.delete(handler); _subscriptions.delete(handler);
}, },
/**
* Set accessibility focus to a react component.
*
* See http://facebook.github.io/react-native/docs/accessibilityinfo.html#setaccessibilityfocus
*/
setAccessibilityFocus: function(reactTag: number): void {
UIManager.sendAccessibilityEvent(
reactTag,
UIManager.AccessibilityEventTypes.typeViewFocused,
);
},
}; };
module.exports = AccessibilityInfo; module.exports = AccessibilityInfo;

2
Libraries/Components/AccessibilityInfo/AccessibilityInfo.ios.js
View File

@ -93,8 +93,6 @@ const AccessibilityInfo = {
/** /**
* Set accessibility focus to a react component. * Set accessibility focus to a react component.
* *
* @platform ios
*
* See http://facebook.github.io/react-native/docs/accessibilityinfo.html#setaccessibilityfocus * See http://facebook.github.io/react-native/docs/accessibilityinfo.html#setaccessibilityfocus
*/ */
setAccessibilityFocus: function(reactTag: number): void { setAccessibilityFocus: function(reactTag: number): void {

2
ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModuleConstants.java
View File

@ -134,6 +134,8 @@ import java.util.Map;
MapBuilder.of( MapBuilder.of(
"typeWindowStateChanged", "typeWindowStateChanged",
AccessibilityEvent.TYPE_WINDOW_STATE_CHANGED, AccessibilityEvent.TYPE_WINDOW_STATE_CHANGED,
"typeViewFocused",
AccessibilityEvent.TYPE_VIEW_FOCUSED,
"typeViewClicked", "typeViewClicked",
AccessibilityEvent.TYPE_VIEW_CLICKED)); AccessibilityEvent.TYPE_VIEW_CLICKED));