Add better markers for getConfig

Reviewed By: astreet

Differential Revision: D3358278

fbshipit-source-id: 16668cd33a42a120c2de88be4cb4a1c8d0d5a13c
This commit is contained in:
Alexander Blom 2016-06-06 11:49:07 -07:00 committed by Facebook Github Bot 8
parent 1dc33b5f23
commit bc7ec03670
1 changed files with 3 additions and 4 deletions

View File

@ -39,6 +39,7 @@ std::vector<std::string> ModuleRegistry::moduleNames() {
}
folly::dynamic ModuleRegistry::getConfig(const std::string& name) {
SystraceSection s("getConfig", "module", name);
auto it = modulesByName_.find(name);
if (it == modulesByName_.end()) {
return nullptr;
@ -51,8 +52,7 @@ folly::dynamic ModuleRegistry::getConfig(const std::string& name) {
folly::dynamic config = folly::dynamic::array(name);
{
SystraceSection s("getConfig constants",
"module", name);
SystraceSection s("getConstants");
folly::dynamic constants = module->getConstants();
if (constants.isObject() && constants.size() > 0) {
config.push_back(std::move(constants));
@ -60,8 +60,7 @@ folly::dynamic ModuleRegistry::getConfig(const std::string& name) {
}
{
SystraceSection s("getConfig methods",
"module", name);
SystraceSection s("getMethods");
std::vector<MethodDescriptor> methods = module->getMethods();
folly::dynamic methodNames = folly::dynamic::array;