Update version number in repo for ecosystem compatibility
Summary:In https://github.com/facebook/react-native/pull/5241 ide updated the version number to be a fake one so that people wouldn't send in PRs just bumping the version. Unfortunately, this leads to compatibility issues when developing against `master` with 3rd-party components that declare React Native as a `peerDependency`. For example, I'm using [react-native-orientation](https://github.com/yamill/react-native-orientation) which has a peerDependency of `"react-native": ">=0.5"`. I see a few ways to deal with this: 1. Only develop against the releases on npm, not git snapshots. 2. Ask ecosystem projects to not include a minimum version of `react-native` in their peerDependencies. 3. Track the RN release numbers in the git repository (eg it would be 0.19 right now). 4. Make the release number on master huge (1000 in this PR) so it's obviously a fake number but will still comply with >= checks. I don't think option 2 is good because it's reasonable for a package author to want to specify a minimum R Closes https://github.com/facebook/react-native/pull/5556 Differential Revision: D3110274 fb-gh-sync-id: 8638157d44ee99945337fbf585936b50699f0341 fbshipit-source-id: 8638157d44ee99945337fbf585936b50699f0341
This commit is contained in:
parent
258b43948f
commit
bbeeaa1274
|
@ -1,6 +1,6 @@
|
|||
{
|
||||
"name": "react-native",
|
||||
"version": "0.0.0-master",
|
||||
"version": "1000.0.0",
|
||||
"description": "A framework for building native apps using React",
|
||||
"license": "BSD-3-Clause",
|
||||
"repository": {
|
||||
|
|
Loading…
Reference in New Issue