status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Test perf impact of most straightforward fix for double detach. 

Summary: This is the most straightforward fix for the double detach issue.  If a view is not attached, then addViewInLayout never propagates onAttach, and adding through attachViewToParent is a no op.  We could hack something in to attach clipped FlatViewGroups in onClippingRect, but any other view that relies on onAttachedToWindow will have similar issues.

Reviewed By: ahmedre

Differential Revision: D3560565
This commit is contained in:
Seth Kirby 2016-07-19 13:54:44 -07:00 committed by Ahmed El-Helw
parent 95ae936aa6
commit bb5ba3d295
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ReactAndroid/src/main/java/com/facebook/react/flat/FlatViewGroup.java
View File

@ -877,18 +877,18 @@ import com.facebook.react.views.view.ReactClippingViewGroupHelper;
// Now off the screen. Don't invalidate in this case, as the canvas should not be // Now off the screen. Don't invalidate in this case, as the canvas should not be
// redrawn unless new elements are coming onscreen. // redrawn unless new elements are coming onscreen.
mClippedSubviews.put(view.getId(), view); mClippedSubviews.put(view.getId(), view);
detachViewFromParent(view); removeViewsInLayout(--index, 1);
drawView.isViewGroupClipped = true; drawView.isViewGroupClipped = true;
index--;
} }
} else { } else {
// Clipped, invisible. // Clipped, invisible.
if (withinBounds(view, clippingRect)) { if (withinBounds(view, clippingRect)) {
// Now on the screen. Invalidate as we have a new element to draw. // Now on the screen. Invalidate as we have a new element to draw.
attachViewToParent( addViewInLayout(
view, view,
index++, index++,
ensureLayoutParams(view.getLayoutParams())); ensureLayoutParams(view.getLayoutParams()),
true);
mClippedSubviews.remove(view.getId()); mClippedSubviews.remove(view.getId());
drawView.isViewGroupClipped = false; drawView.isViewGroupClipped = false;
needsInvalidate = true; needsInvalidate = true;