status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-25 07:35:25 +00:00
Code Issues Projects Releases Wiki Activity

adding error message including stacktrace and example

Browse Source 
Reviewed By: fkgozali

Differential Revision: D5908789

fbshipit-source-id: 061e414d5105df607b7dcafefb134ad9c94a9a71
This commit is contained in:
David Vacca 2017-09-25 21:55:56 -07:00 committed by Facebook Github Bot
parent 29e7659111
commit b694f96762
3 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/Image/Image.android.js
View File

@ -272,6 +272,10 @@ var Image = createReactClass({
console.warn('The <Image> component requires a `source` property rather than `src`.');
}
if (this.props.children) {
throw new Error('The <Image> component cannot contain children. If you want to render content on top of the image, consider using aboslute positioning.');
}
if (source && (source.uri || Array.isArray(source))) {
let style;
let sources;

4
Libraries/Image/Image.ios.js
View File

@ -374,6 +374,10 @@ const Image = createReactClass({
console.warn('The <Image> component requires a `source` property rather than `src`.');
}
if (this.props.children) {
throw new Error('The <Image> component cannot contain children. If you want to render content on top of the image, consider using aboslute positioning.');
}
return (
<RCTImageView
{...this.props}

17
RNTester/js/ImageExample.js
View File

@ -439,7 +439,22 @@ exports.examples = [
},
},
{
title: 'Nesting',
title: 'Nesting content inside <Image> component',
render: function() {
return (
<View style={{width: 60, height: 60}}>
<Image
style={{...StyleSheet.absoluteFillObject}}
source={fullImage}/>
<Text style={styles.nestedText}>
React
</Text>
</View>
);
},
},
{
title: 'Nesting content inside <ImageBackground> component',
render: function() {
return (
<ImageBackground