metro: allow dynamic dependencies from within node_modules
Summary: Tries to adress https://github.com/facebook/metro/issues/65. We need a reasonnable workaround to support modules like `moment.js` that do dynamic requires but only in some cases. By replacing the call by a function that throws, we move the exception at runtime instead of happening at compile time. We don't want to do that for non-node_modules file because they are fixable directly, while `node_modules` are not fixable by people and they get completely blocked by the error at compile time. Reviewed By: rafeca Differential Revision: D6736989 fbshipit-source-id: a6e1fd9b56fa83907400884efd8f8594018b7c37
This commit is contained in:
parent
d40db3a715
commit
b5e19adc02
|
@ -94,6 +94,7 @@ async function buildBundle(
|
|||
assetExts: defaultAssetExts.concat(assetExts),
|
||||
assetRegistryPath: ASSET_REGISTRY_PATH,
|
||||
blacklistRE: config.getBlacklistRE(),
|
||||
dynamicDepsInPackages: config.dynamicDepsInPackages,
|
||||
extraNodeModules: config.extraNodeModules,
|
||||
getModulesRunBeforeMainModule: config.getModulesRunBeforeMainModule,
|
||||
getPolyfills: config.getPolyfills,
|
||||
|
|
|
@ -31,6 +31,7 @@ function dependencies(argv, config, args, packagerInstance) {
|
|||
assetRegistryPath: ASSET_REGISTRY_PATH,
|
||||
projectRoots: config.getProjectRoots(),
|
||||
blacklistRE: config.getBlacklistRE(),
|
||||
dynamicDepsInPackages: config.dynamicDepsInPackages,
|
||||
getPolyfills: config.getPolyfills,
|
||||
getTransformOptions: config.getTransformOptions,
|
||||
hasteImpl: config.hasteImpl,
|
||||
|
|
|
@ -179,6 +179,7 @@ function getPackagerServer(args, config, reporter) {
|
|||
cacheVersion: '3',
|
||||
enableBabelRCLookup: config.getEnableBabelRCLookup(),
|
||||
extraNodeModules: config.extraNodeModules,
|
||||
dynamicDepsInPackages: config.dynamicDepsInPackages,
|
||||
getModulesRunBeforeMainModule: config.getModulesRunBeforeMainModule,
|
||||
getPolyfills: config.getPolyfills,
|
||||
getTransformOptions: config.getTransformOptions,
|
||||
|
|
Loading…
Reference in New Issue