status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix spannable flags in RCTVirtualText 

Summary:
The spannable flags for RCTVirtualText were always being set to
INCLUSIVE_EXCLUSIVE - this is different than the behavior that is found in
ReactTextShadowNode, which sets EXCLUSIVE_INCLUSIVE as the default flag
unless the text is at the beginning.

This is needed to fix various problems with TextInput, including the handling
of empty spans (see also D2962394 which depends on this patch), and making the
behavior consistent when styled children of a TextInput are changed.

Differential Revision: D2962643
This commit is contained in:
Ahmed El-Helw 2016-02-24 14:21:47 -08:00
parent 055b31a165
commit b4100ef246
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ReactAndroid/src/main/java/com/facebook/react/flat/RCTVirtualText.java
View File

@ -50,11 +50,17 @@ import com.facebook.react.uimanager.ViewProps;
protected void performApplySpans(SpannableStringBuilder builder, int begin, int end) {
mFontStylingSpan.freeze();
// All spans will automatically extend to the right of the text, but not the left - except
// for spans that start at the beginning of the text.
final int flag = begin == 0 ?
Spannable.SPAN_INCLUSIVE_INCLUSIVE :
Spannable.SPAN_EXCLUSIVE_INCLUSIVE;
builder.setSpan(
mFontStylingSpan,
begin,
end,
Spannable.SPAN_INCLUSIVE_EXCLUSIVE);
flag);
if (mShadowStyleSpan.getColor() != 0 && mShadowStyleSpan.getRadius() != 0) {
mShadowStyleSpan.freeze();
@ -63,7 +69,7 @@ import com.facebook.react.uimanager.ViewProps;
mShadowStyleSpan,
begin,
end,
Spannable.SPAN_INCLUSIVE_EXCLUSIVE);
flag);
}
for (int i = 0, childCount = getChildCount(); i < childCount; ++i) {