status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Adding support to float values for Android snapToInterval 

Reviewed By: fkgozali

Differential Revision: D6684529

fbshipit-source-id: 51efa0a2d38acf4134bb824c462973e5c6bdf17a
This commit is contained in:
David Vacca 2018-01-09 12:07:45 -08:00 committed by Facebook Github Bot
parent a8d4666651
commit b2848a54b0
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RNTester/js/ScrollViewSimpleExample.js
View File

@ -50,7 +50,7 @@ class ScrollViewSimpleExample extends React.Component<{}> {
<ScrollView <ScrollView
key={'scrollViewSnap'} key={'scrollViewSnap'}
horizontal horizontal
snapToInterval={210} snapToInterval={210.0}
pagingEnabled pagingEnabled
> >
{this.makeItems(NUM_ITEMS, [ {this.makeItems(NUM_ITEMS, [

5
ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollViewManager.java
View File

@ -73,9 +73,10 @@ public class ReactHorizontalScrollViewManager
} }
@ReactProp(name = "snapToInterval") @ReactProp(name = "snapToInterval")
public void setSnapToInterval(ReactHorizontalScrollView view, int snapToInterval) { public void setSnapToInterval(ReactHorizontalScrollView view, float snapToInterval) {
// snapToInterval needs to be exposed as a float because of the Javascript interface.
DisplayMetrics screenDisplayMetrics = DisplayMetricsHolder.getScreenDisplayMetrics(); DisplayMetrics screenDisplayMetrics = DisplayMetricsHolder.getScreenDisplayMetrics();
view.setSnapInterval((int)(snapToInterval * screenDisplayMetrics.density)); view.setSnapInterval((int) (snapToInterval * screenDisplayMetrics.density));
} }
@ReactProp(name = ReactClippingViewGroupHelper.PROP_REMOVE_CLIPPED_SUBVIEWS) @ReactProp(name = ReactClippingViewGroupHelper.PROP_REMOVE_CLIPPED_SUBVIEWS)