Pool dynamic
Reviewed By: ahmedre Differential Revision: D4398446 fbshipit-source-id: ff528b7b52a2b1521627c0fca17b7ee2b18102de
This commit is contained in:
parent
1d9ba508c4
commit
b27c541744
|
@ -25,6 +25,7 @@ android_library(
|
||||||
react_native_dep('java/com/facebook/systrace:systrace'),
|
react_native_dep('java/com/facebook/systrace:systrace'),
|
||||||
react_native_dep('libraries/fbcore/src/main/java/com/facebook/common/logging:logging'),
|
react_native_dep('libraries/fbcore/src/main/java/com/facebook/common/logging:logging'),
|
||||||
react_native_dep('libraries/soloader/java/com/facebook/soloader:soloader'),
|
react_native_dep('libraries/soloader/java/com/facebook/soloader:soloader'),
|
||||||
|
react_native_dep('third-party/android/support/v4:lib-support-v4'),
|
||||||
react_native_dep('third-party/java/infer-annotations:infer-annotations'),
|
react_native_dep('third-party/java/infer-annotations:infer-annotations'),
|
||||||
react_native_dep('third-party/java/jsr-305:jsr-305'),
|
react_native_dep('third-party/java/jsr-305:jsr-305'),
|
||||||
react_native_target('java/com/facebook/react/common:common'),
|
react_native_target('java/com/facebook/react/common:common'),
|
||||||
|
@ -33,4 +34,3 @@ android_library(
|
||||||
'PUBLIC',
|
'PUBLIC',
|
||||||
],
|
],
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
|
@ -121,7 +121,7 @@ public abstract class BaseJavaModule implements NativeModule {
|
||||||
@Override
|
@Override
|
||||||
public Dynamic extractArgument(
|
public Dynamic extractArgument(
|
||||||
CatalystInstance catalystInstance, ExecutorToken executorToken, ReadableNativeArray jsArguments, int atIndex) {
|
CatalystInstance catalystInstance, ExecutorToken executorToken, ReadableNativeArray jsArguments, int atIndex) {
|
||||||
return new DynamicFromArray(jsArguments, atIndex);
|
return DynamicFromArray.create(jsArguments, atIndex);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -21,4 +21,5 @@ public interface Dynamic {
|
||||||
ReadableArray asArray();
|
ReadableArray asArray();
|
||||||
ReadableMap asMap();
|
ReadableMap asMap();
|
||||||
ReadableType getType();
|
ReadableType getType();
|
||||||
|
void recycle();
|
||||||
}
|
}
|
||||||
|
|
|
@ -9,51 +9,92 @@
|
||||||
|
|
||||||
package com.facebook.react.bridge;
|
package com.facebook.react.bridge;
|
||||||
|
|
||||||
|
import javax.annotation.Nullable;
|
||||||
|
|
||||||
|
import android.support.v4.util.Pools;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Implementation of Dynamic wrapping a ReadableArray.
|
* Implementation of Dynamic wrapping a ReadableArray.
|
||||||
*/
|
*/
|
||||||
public class DynamicFromArray implements Dynamic {
|
public class DynamicFromArray implements Dynamic {
|
||||||
|
private static final Pools.SimplePool<DynamicFromArray> sPool = new Pools.SimplePool<>(10);
|
||||||
|
|
||||||
private final ReadableArray mArray;
|
private @Nullable ReadableArray mArray;
|
||||||
private final int mIndex;
|
private int mIndex = -1;
|
||||||
|
|
||||||
public DynamicFromArray(ReadableArray array, int index) {
|
// This is a pools object. Hide the constructor.
|
||||||
mArray = array;
|
private DynamicFromArray() {}
|
||||||
mIndex = index;
|
|
||||||
|
public static DynamicFromArray create(ReadableArray array, int index) {
|
||||||
|
DynamicFromArray dynamic = sPool.acquire();
|
||||||
|
if (dynamic == null) {
|
||||||
|
dynamic = new DynamicFromArray();
|
||||||
|
}
|
||||||
|
dynamic.mArray = array;
|
||||||
|
dynamic.mIndex = index;
|
||||||
|
return dynamic;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void recycle() {
|
||||||
|
mArray = null;
|
||||||
|
mIndex = -1;
|
||||||
|
sPool.release(this);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean asBoolean() {
|
public boolean asBoolean() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getBoolean(mIndex);
|
return mArray.getBoolean(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public double asDouble() {
|
public double asDouble() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getDouble(mIndex);
|
return mArray.getDouble(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int asInt() {
|
public int asInt() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getInt(mIndex);
|
return mArray.getInt(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public String asString() {
|
public String asString() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getString(mIndex);
|
return mArray.getString(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableArray asArray() {
|
public ReadableArray asArray() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getArray(mIndex);
|
return mArray.getArray(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableMap asMap() {
|
public ReadableMap asMap() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getMap(mIndex);
|
return mArray.getMap(mIndex);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableType getType() {
|
public ReadableType getType() {
|
||||||
|
if (mArray == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mArray.getType(mIndex);
|
return mArray.getType(mIndex);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -9,51 +9,92 @@
|
||||||
|
|
||||||
package com.facebook.react.bridge;
|
package com.facebook.react.bridge;
|
||||||
|
|
||||||
|
import javax.annotation.Nullable;
|
||||||
|
|
||||||
|
import android.support.v4.util.Pools;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Implementation of Dynamic wrapping a ReadableMap.
|
* Implementation of Dynamic wrapping a ReadableMap.
|
||||||
*/
|
*/
|
||||||
public class DynamicFromMap implements Dynamic {
|
public class DynamicFromMap implements Dynamic {
|
||||||
|
private static final Pools.SimplePool<DynamicFromMap> sPool = new Pools.SimplePool<>(10);
|
||||||
|
|
||||||
private final ReadableMap mMap;
|
private @Nullable ReadableMap mMap;
|
||||||
private final String mName;
|
private @Nullable String mName;
|
||||||
|
|
||||||
public DynamicFromMap(ReadableMap map, String name) {
|
// This is a pools object. Hide the constructor.
|
||||||
mMap = map;
|
private DynamicFromMap() {}
|
||||||
mName = name;
|
|
||||||
|
public static DynamicFromMap create(ReadableMap map, String name) {
|
||||||
|
DynamicFromMap dynamic = sPool.acquire();
|
||||||
|
if (dynamic == null) {
|
||||||
|
dynamic = new DynamicFromMap();
|
||||||
|
}
|
||||||
|
dynamic.mMap = map;
|
||||||
|
dynamic.mName = name;
|
||||||
|
return dynamic;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void recycle() {
|
||||||
|
mMap = null;
|
||||||
|
mName = null;
|
||||||
|
sPool.release(this);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public boolean asBoolean() {
|
public boolean asBoolean() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getBoolean(mName);
|
return mMap.getBoolean(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public double asDouble() {
|
public double asDouble() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getDouble(mName);
|
return mMap.getDouble(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int asInt() {
|
public int asInt() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getInt(mName);
|
return mMap.getInt(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public String asString() {
|
public String asString() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getString(mName);
|
return mMap.getString(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableArray asArray() {
|
public ReadableArray asArray() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getArray(mName);
|
return mMap.getArray(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableMap asMap() {
|
public ReadableMap asMap() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getMap(mName);
|
return mMap.getMap(mName);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ReadableType getType() {
|
public ReadableType getType() {
|
||||||
|
if (mMap == null || mName == null) {
|
||||||
|
throw new IllegalStateException("This dynamic value has been recycled");
|
||||||
|
}
|
||||||
return mMap.getType(mName);
|
return mMap.getType(mName);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -90,7 +90,7 @@ public class JavaOnlyArray implements ReadableArray, WritableArray {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Dynamic getDynamic(int index) {
|
public Dynamic getDynamic(int index) {
|
||||||
return new DynamicFromArray(this, index);
|
return DynamicFromArray.create(this, index);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|
|
@ -90,7 +90,7 @@ public class JavaOnlyMap implements ReadableMap, WritableMap {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Dynamic getDynamic(String name) {
|
public Dynamic getDynamic(String name) {
|
||||||
return new DynamicFromMap(this, name);
|
return DynamicFromMap.create(this, name);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|
|
@ -49,7 +49,7 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Dynamic getDynamic(int index) {
|
public Dynamic getDynamic(int index) {
|
||||||
return new DynamicFromArray(this, index);
|
return DynamicFromArray.create(this, index);
|
||||||
}
|
}
|
||||||
|
|
||||||
public ArrayList<Object> toArrayList() {
|
public ArrayList<Object> toArrayList() {
|
||||||
|
|
|
@ -49,7 +49,7 @@ public class ReadableNativeMap extends NativeMap implements ReadableMap {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public Dynamic getDynamic(String name) {
|
public Dynamic getDynamic(String name) {
|
||||||
return new DynamicFromMap(this, name);
|
return DynamicFromMap.create(this, name);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
|
Loading…
Reference in New Issue