From b10474c33320f9ee662192333e9cb0fc42ead349 Mon Sep 17 00:00:00 2001 From: Denis Koroskin Date: Tue, 5 Jan 2016 12:58:45 -0800 Subject: [PATCH] Disallow mounting virtual nodes to Views Summary: Virtual shadow nodes, such as RCTRawText, RCTTextInlineImage etc cannot be mounted to a View (ViewManager will throw an Exception if we ever try to). This diff is adding a check to make sure that Exception is never thrown. Reviewed By: ahmedre Differential Revision: D2800869 --- .../src/main/java/com/facebook/react/flat/FlatShadowNode.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java index d4af1867c..40b8f4753 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/flat/FlatShadowNode.java @@ -254,6 +254,10 @@ import com.facebook.react.uimanager.ViewProps; } /* package */ final void forceMountToView() { + if (isVirtual()) { + return; + } + if (mDrawView == null) { mDrawView = DrawView.INSTANCE; if (getParent() != null) {