status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-10 00:23:26 +00:00
Code Issues Projects Releases Wiki Activity

Codemod Internal Unit Tests and Remove Require Fallback

Browse Source 
Summary:
MessageQueue no longer falls back to require. To do this we need to register all the modules in our internal unit tests. I did this codemod manually.

This is a bit unfortunate boilerplate but there are very few of these modules outside of unit tests. This boilerplate is only a hassle for these test files.

public

Reviewed By: spicyj

Differential Revision: D2736397

fb-gh-sync-id: 59fa4c4e75c538f3577bc9693b93e1b7c4d4d233
This commit is contained in:
Sebastian Markbage 2015-12-10 23:15:38 -08:00 committed by facebook-github-bot-0
parent b78b8f6cab
commit ae912a83d7
1 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Libraries/Utilities/MessageQueue.js
View File

@ -159,20 +159,11 @@ class MessageQueue {
console.log('N->JS : ' + module + '.' + method + '(' + JSON.stringify(args) + ')'); console.log('N->JS : ' + module + '.' + method + '(' + JSON.stringify(args) + ')');
} }
var moduleMethods = this._callableModules[module]; var moduleMethods = this._callableModules[module];
if (!moduleMethods) { invariant(
// TODO: Register all the remaining test modules and make this an invariant. #9317773 !!moduleMethods,
// Fallback to require temporarily. A follow up diff will clean up the remaining 'Module %s is not a registered callable module.',
// modules and make this an invariant. module
console.warn('Module is not registered:', module); );
moduleMethods = require(module);
/*
invariant(
!!moduleMethods,
'Module %s is not a registered callable module.',
module
);
*/
}
moduleMethods[method].apply(moduleMethods, args); moduleMethods[method].apply(moduleMethods, args);
BridgeProfiling.profileEnd(); BridgeProfiling.profileEnd();
} }