status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

enable versionning in xcode project 

Summary:
Current Xcode project does not include settings to enable auto-incrementing build numbers using ```agvtool``` as described [here](https://developer.apple.com/library/ios/qa/qa1827/_index.html). Tools like Fastlane, for example, rely on this for commands like ```increment_build_number```. Having these settings enabled by default ensures that people will have one less thing to worry about setting up CI for RN based projects.
Closes https://github.com/facebook/react-native/pull/9511

Differential Revision: D3841281

Pulled By: javache

fbshipit-source-id: 9b9640edf608efd0835371dbe90a2f51786748af
This commit is contained in:
Philip Nuzhnyy 2016-09-09 04:20:42 -07:00 committed by Facebook Github Bot 7
parent 588f0b83e1
commit ad0c8e63fc
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
local-cli/generator-ios/templates/xcodeproj/project.pbxproj
View File

@ -606,6 +606,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = NO;
HEADER_SEARCH_PATHS = (
"$(inherited)",
@ -620,6 +621,7 @@
"-lc++",
);
PRODUCT_NAME = <%= name %>;
VERSIONING_SYSTEM = "apple-generic";
};
name = Debug;
};
@ -627,6 +629,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CURRENT_PROJECT_VERSION = 1;
HEADER_SEARCH_PATHS = (
"$(inherited)",
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include,
@ -640,6 +643,7 @@
"-lc++",
);
PRODUCT_NAME = <%= name %>;
VERSIONING_SYSTEM = "apple-generic";
};
name = Release;
};