From aac7f5b3620fbedd7d240352333a1fc83b9afca3 Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Mon, 16 May 2016 12:15:22 -0700 Subject: [PATCH] Fix tests buck build when running locally Summary: Got this error when trying to run instrumentation tests locally with `./scripts/run-android-local-integration-test.sh` ``` C:\Users\janic\Developer\react-native\ReactAndroid\src\androidTest\java\com\facebook\react\tests\DatePickerDialogTestCase.java:110: error: cannot access com.facebook.react.modules.core.DefaultHardwareBackBtnHandler return (DialogFragment) getActivity().getSupportFragmentManager() ^ class file for com.facebook.react.modules.core.DefaultHardwareBackBtnHandler not found C:\Users\janic\Developer\react-native\ReactAndroid\src\androidTest\java\com\facebook\react\tests\ViewRenderingTestCase.java:82: error: cannot access com.facebook.react.touch.ReactInterceptingViewGroup assertEquals("Incorrect (or not applied) opacity", expectedOpacity, view.getAlpha()); ^ class file for com.facebook.react.touch.ReactInterceptingViewGroup not found C:\Users\janic\Developer Closes https://github.com/facebook/react-native/pull/7575 Differential Revision: D3306330 fbshipit-source-id: a6d8afd060b54d56f9e2b97f45b642d7b7f46209 --- .gitignore | 3 +++ .../src/androidTest/java/com/facebook/react/tests/BUCK | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index cea273d50..8a35f1be2 100644 --- a/.gitignore +++ b/.gitignore @@ -49,3 +49,6 @@ node_modules # OS X .DS_Store + +# Test generated files +/ReactAndroid/src/androidTest/assets/AndroidTestBundle.js diff --git a/ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK b/ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK index 60795c49a..33759db55 100644 --- a/ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK +++ b/ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK @@ -11,12 +11,14 @@ SANDCASTLE_FLAKY = [ deps = [ react_native_integration_tests_target('java/com/facebook/react/testing:testing'), - react_native_target('java/com/facebook/react/bridge:bridge'), react_native_target('java/com/facebook/react:react'), + react_native_target('java/com/facebook/react/bridge:bridge'), react_native_target('java/com/facebook/react/common:common'), - react_native_target('java/com/facebook/react/modules/timepicker:timepicker'), + react_native_target('java/com/facebook/react/modules/core:core'), react_native_target('java/com/facebook/react/modules/datepicker:datepicker'), react_native_target('java/com/facebook/react/modules/systeminfo:systeminfo'), + react_native_target('java/com/facebook/react/modules/timepicker:timepicker'), + react_native_target('java/com/facebook/react/touch:touch'), react_native_target('java/com/facebook/react/uimanager:uimanager'), react_native_target('java/com/facebook/react/uimanager/annotations:annotations'), react_native_target('java/com/facebook/react/views/picker:picker'),