status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix 2 bugs in FlatUIImplementation.removeChild() 

Summary:
There are 2 issues in removeChild() implementation.

a) There is a chance that a node that we are removing will be mounting to a View, but the create view request has not be created  so there is no backing View for it yet. In that case, FlatNativeViewHierarchyManager.dropView() will throw an Exception failing to find the View. The fix is to only dropView() if one was (requested to be) created.
b) If the shadow node that we are removing doesn't mount to a View, but one or more of its children do, those Views will leak because noone is removing them. The fix is to recursively call removeChild() until we find a node that mounts to a View.

Reviewed By: ahmedre

Differential Revision: D2974938
This commit is contained in:
Denis Koroskin 2016-02-24 20:16:40 -08:00 committed by Ahmed El-Helw
parent 5305f3b68e
commit a9c88bce14
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ReactAndroid/src/main/java/com/facebook/react/flat/FlatUIImplementation.java
View File

@ -274,10 +274,15 @@ public class FlatUIImplementation extends UIImplementation {
* and drops all Views used by it and its children.
*/
private void removeChild(FlatShadowNode child) {
if (child.mountsToView()) {
if (child.mountsToView() && child.isBackingViewCreated()) {
// this will recursively drop all subviews
mStateBuilder.dropView(child);
} else {
for (int i = 0, childCount = child.getChildCount(); i != childCount; ++i) {
removeChild((FlatShadowNode) child.getChildAt(i));
}
}
removeShadowNode(child);
}