status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

support plain numbers in add and multiply operators 

Summary:This adds support for passing plain numbers into the add and multiply operators. This can be useful if you want to have one AnimatedValue for a component that is say a scale 0 -> 1 and then animated many style properties accordingly using derivative Animated values.

Thoughts?

As far as implementation, there may be more performant implementations that do not require creating a whole new AnimatedValue for every static number. I am open to suggestion.
Closes https://github.com/facebook/react-native/pull/6154

Differential Revision: D2979962

Pulled By: vjeux

fb-gh-sync-id: b5ecb568b4c64b995dc4100991f02c17f0dd97dd
shipit-source-id: b5ecb568b4c64b995dc4100991f02c17f0dd97dd
This commit is contained in:
Zack 2016-02-25 16:59:22 -08:00 committed by facebook-github-bot-7
parent 8b88cae747
commit a9846da9fa
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/Animated/src/AnimatedImplementation.js
View File

@ -844,10 +844,10 @@ class AnimatedAddition extends AnimatedWithChildren {
_a: Animated;
_b: Animated;
constructor(a: Animated, b: Animated) {
constructor(a: Animated | number, b: Animated | number) {
super();
this._a = a;
this._b = b;
this._a = typeof a === 'number' ? new AnimatedValue(a) : a;
this._b = typeof b === 'number' ? new AnimatedValue(b) : b;
}
__getValue(): number {
@ -873,10 +873,10 @@ class AnimatedMultiplication extends AnimatedWithChildren {
_a: Animated;
_b: Animated;
constructor(a: Animated, b: Animated) {
constructor(a: Animated | number, b: Animated | number) {
super();
this._a = a;
this._b = b;
this._a = typeof a === 'number' ? new AnimatedValue(a) : a;
this._b = typeof b === 'number' ? new AnimatedValue(b) : b;
}
__getValue(): number {