status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-13 19:15:05 +00:00
Code Issues Projects Releases Wiki Activity

Added ReactCommon to package.json to allow for building locally

Browse Source 
Summary:
This pull request solves an error building from source as noted in https://github.com/facebook/react-native/issues/7911 and https://github.com/facebook/react-native/pull/7118. The error says BUILD FAILED due to cxxreact module not found. Previously the ReactCommon folder was excluded when installed from npm. There may be a better way to include this folder, but I'm unfamiliar with FB's build process.

**Test plan (required)**

Create a new sample project by npm init, npm install --save https://github.com/opensports/react-native.git. Then run react-native run-android and the project should build successfully.
Closes https://github.com/facebook/react-native/pull/7929

Differential Revision: D3391332

fbshipit-source-id: 710cb741cea2e212767b21d606e3a459347b0fb9
This commit is contained in:
James 2016-06-05 14:06:10 -07:00 committed by Facebook Github Bot 3
parent 8c3db9782e
commit a966c85fce
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
package.json
View File

@ -99,6 +99,7 @@
"React",
"React.podspec",
"ReactAndroid",
"ReactCommon",
"react.gradle",
"android",
"Libraries",