status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Moving more logs from Log -> Flog 

Reviewed By: fkgozali

Differential Revision: D8433247

fbshipit-source-id: e666fbf2abb81697ba6fb508c149af8a1a2035f1
This commit is contained in:
David Vacca 2018-06-17 11:41:09 -07:00 committed by Facebook Github Bot
parent 15f84420f0
commit a7e8e72c51
4 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
View File

@ -20,7 +20,6 @@ import com.facebook.debug.tags.ReactDebugOverlayTags;
import com.facebook.infer.annotation.Assertions; import com.facebook.infer.annotation.Assertions;
import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.JavaScriptContextHolder; import com.facebook.react.bridge.JavaScriptContextHolder;
import com.facebook.react.bridge.PerformanceCounter;
import com.facebook.react.bridge.ReactApplicationContext; import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.ReadableMap;

6
ReactAndroid/src/main/java/com/facebook/react/fabric/Scheduler.java
View File

@ -1,6 +1,6 @@
package com.facebook.react.fabric; package com.facebook.react.fabric;
import android.util.Log; import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReactContext;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.LinkedBlockingDeque; import java.util.concurrent.LinkedBlockingDeque;
@ -56,7 +56,7 @@ public class Scheduler {
try { try {
work.run(); work.run();
} catch (Exception ex) { } catch (Exception ex) {
Log.w(TAG, "Exception running work in JS.", ex); FLog.w(TAG, "Exception running work in JS.", ex);
throw ex; throw ex;
} }
} }
@ -66,7 +66,7 @@ public class Scheduler {
} catch (RejectedExecutionException ex) { } catch (RejectedExecutionException ex) {
// This can happen if a Work is scheduled when the Scheduler is being shutdown. // This can happen if a Work is scheduled when the Scheduler is being shutdown.
// For now, we log and do not take any action. // For now, we log and do not take any action.
Log.i(TAG, "Unable to schedule task."); FLog.i(TAG, "Unable to schedule task.");
} }
} }

10
ReactAndroid/src/main/java/com/facebook/react/fabric/events/FabricEventEmitter.java
View File

@ -15,8 +15,8 @@ import static com.facebook.react.uimanager.events.TouchesHelper.TOUCHES_KEY;
import android.annotation.TargetApi; import android.annotation.TargetApi;
import android.os.Build; import android.os.Build;
import android.util.Log;
import android.util.Pair; import android.util.Pair;
import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.ReactApplicationContext; import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableArray; import com.facebook.react.bridge.WritableArray;
@ -29,8 +29,6 @@ import com.facebook.react.fabric.Work;
import com.facebook.react.uimanager.IllegalViewOperationException; import com.facebook.react.uimanager.IllegalViewOperationException;
import com.facebook.react.uimanager.events.RCTEventEmitter; import com.facebook.react.uimanager.events.RCTEventEmitter;
import java.io.Closeable; import java.io.Closeable;
import java.io.IOException;
import java.util.Arrays;
import java.util.HashSet; import java.util.HashSet;
import java.util.Set; import java.util.Set;
import javax.annotation.Nullable; import javax.annotation.Nullable;
@ -54,7 +52,7 @@ public class FabricEventEmitter implements RCTEventEmitter, Closeable {
long eventTarget = mFabricUIManager.createEventTarget(reactTag); long eventTarget = mFabricUIManager.createEventTarget(reactTag);
mScheduler.scheduleWork(new FabricUIManagerWork(eventTarget, eventName, params)); mScheduler.scheduleWork(new FabricUIManagerWork(eventTarget, eventName, params));
} catch (IllegalViewOperationException e) { } catch (IllegalViewOperationException e) {
Log.e(TAG, "Unable to emmit event for tag " + reactTag, e); FLog.e(TAG, "Unable to emmit event for tag " + reactTag, e);
} }
} }
@ -79,7 +77,7 @@ public class FabricEventEmitter implements RCTEventEmitter, Closeable {
try { try {
mFabricUIManager.invoke(mEventTarget, mEventName, mParams); mFabricUIManager.invoke(mEventTarget, mEventName, mParams);
} catch (Throwable t) { } catch (Throwable t) {
Log.e(TAG, "Error sending event " + mEventName, t); FLog.e(TAG, "Error sending event " + mEventName, t);
//TODO: manage exception properly //TODO: manage exception properly
} finally{ } finally{
mFabricUIManager.releaseEventTarget(mEventTarget); mFabricUIManager.releaseEventTarget(mEventTarget);
@ -109,7 +107,7 @@ public class FabricEventEmitter implements RCTEventEmitter, Closeable {
int rootNodeID = 0; int rootNodeID = 0;
int target = nativeEvent.getInt(TARGET_KEY); int target = nativeEvent.getInt(TARGET_KEY);
if (target < 1) { if (target < 1) {
Log.e(TAG,"A view is reporting that a touch occurred on tag zero."); FLog.e(TAG,"A view is reporting that a touch occurred on tag zero.");
} else { } else {
rootNodeID = target; rootNodeID = target;
} }

6
ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java
View File

@ -10,7 +10,7 @@ package com.facebook.react.uimanager;
import android.annotation.TargetApi; import android.annotation.TargetApi;
import android.content.res.Resources; import android.content.res.Resources;
import android.os.Build; import android.os.Build;
import android.util.Log; import com.facebook.common.logging.FLog;
import android.util.SparseArray; import android.util.SparseArray;
import android.util.SparseBooleanArray; import android.util.SparseBooleanArray;
import android.view.Menu; import android.view.Menu;
@ -123,7 +123,7 @@ public class NativeViewHierarchyManager {
try { try {
updateInstanceHandle(resolveView(tag), instanceHandle); updateInstanceHandle(resolveView(tag), instanceHandle);
} catch (IllegalViewOperationException e) { } catch (IllegalViewOperationException e) {
Log.e(TAG, "Unable to update properties for view tag " + tag, e); FLog.e(TAG, "Unable to update properties for view tag " + tag, e);
} }
} }
@ -138,7 +138,7 @@ public class NativeViewHierarchyManager {
viewManager.updateProperties(viewToUpdate, props); viewManager.updateProperties(viewToUpdate, props);
} }
} catch (IllegalViewOperationException e) { } catch (IllegalViewOperationException e) {
Log.e(TAG, "Unable to update properties for view tag " + tag, e); FLog.e(TAG, "Unable to update properties for view tag " + tag, e);
} }
} }