Deploy v0.38.0

Reviewed By: jeffmo

Differential Revision: D4428858

fbshipit-source-id: 10dc69349a2b563e1fa444a8b0612e3b2d4ccd1c

.flowconfig

@@ -39,11 +39,11 @@ suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(3[0-7]\\|[1-2][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(3[0-7]\\|1[0-9]\\|[1-2][0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(3[0-8]\\|[1-2][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(3[0-8]\\|1[0-9]\\|[1-2][0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.37.0
+^0.38.0

Libraries/Alert/Alert.js

@@ -17,6 +17,8 @@ var DialogModuleAndroid = require('NativeModules').DialogManagerAndroid;
 
 import type { AlertType, AlertButtonStyle } from 'AlertIOS';
 
+/* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+ * deployment of v0.38.0. To see the error, remove this comment and run flow */
 type Buttons = Array<{
   text?: string,
   onPress?: ?Function,

Libraries/Animated/src/Interpolation.js

@@ -19,6 +19,9 @@ type ExtrapolateType = 'extend' | 'identity' | 'clamp';
 
 export type InterpolationConfigType = {
   inputRange: Array<number>,
+  /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+   * deployment of v0.38.0. To see the error, remove this comment and run flow
+   */
   outputRange: (Array<number> | Array<string>),
   easing?: ((input: number) => number),
   extrapolate?: ExtrapolateType,

Libraries/BatchedBridge/MessageQueue.js

@@ -157,8 +157,14 @@ class MessageQueue {
         }
       }
       onFail && params.push(this._callbackID);
+      /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+       * the deployment of v0.38.0. To see the error, remove this comment and
+       * run flow */
       this._callbacks[this._callbackID++] = onFail;
       onSucc && params.push(this._callbackID);
+      /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+       * the deployment of v0.38.0. To see the error, remove this comment and
+       * run flow */
       this._callbacks[this._callbackID++] = onSucc;
     }
 
@@ -270,7 +276,13 @@ class MessageQueue {
       }
     }
 
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._callbacks[cbID & ~1] = null;
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._callbacks[cbID |  1] = null;
     // $FlowIssue(>=0.35.0) #14551610
     callback.apply(null, args);

Libraries/Core/Timers/JSTimersExecution.js

@@ -112,6 +112,9 @@ const JSTimersExecution = {
       if (!JSTimersExecution.errors) {
         JSTimersExecution.errors = [e];
       } else {
+        /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected
+         * during the deployment of v0.38.0. To see the error, remove this
+         * comment and run flow */
         JSTimersExecution.errors.push(e);
       }
     }

Libraries/NavigationExperimental/NavigationTransitioner.js

@@ -259,13 +259,15 @@ function buildTransitionProps(
     scenes,
   } = state;
 
+  /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+   * deployment of v0.38.0. To see the error, remove this comment and run flow
+   */
   return {
     layout,
     navigationState,
     position,
     progress,
     scenes,
-    // $FlowFixMe(>=0.32.0) - find can return undefined
     scene: scenes.find(isSceneActive),
   };
 }

Libraries/Network/XMLHttpRequest.js

@@ -393,6 +393,9 @@ class XMLHttpRequest extends EventTarget(...XHR_EVENTS) {
     (this._subscriptions || []).forEach(sub => {
       sub.remove();
     });
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions = [];
   }
 
@@ -457,26 +460,44 @@ class XMLHttpRequest extends EventTarget(...XHR_EVENTS) {
       !!this.onreadystatechange ||
       !!this.onprogress;
 
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didSendNetworkData',
       (args) => this.__didUploadProgress(...args)
     ));
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didReceiveNetworkResponse',
       (args) => this.__didReceiveResponse(...args)
     ));
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didReceiveNetworkData',
       (args) => this.__didReceiveData(...args)
     ));
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didReceiveNetworkIncrementalData',
       (args) => this.__didReceiveIncrementalData(...args)
     ));
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didReceiveNetworkDataProgress',
       (args) => this.__didReceiveDataProgress(...args)
     ));
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     this._subscriptions.push(RCTNetworking.addListener(
       'didCompleteNetworkResponse',
       (args) => this.__didCompleteResponse(...args)

Libraries/ReactNative/requireNativeComponent.js

@@ -112,6 +112,9 @@ const TypeToDifferMap = {
 };
 
 function processColorArray(colors: []): [] {
+  /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+   * deployment of v0.38.0. To see the error, remove this comment and run flow
+   */
   return colors && colors.map(processColor);
 }
 

Libraries/Renderer/src/renderers/shared/fiber/ReactFiber.js

@@ -57,6 +57,8 @@ type Instance = {
 
 // A Fiber is work on a Component that needs to be done or was done. There can
 // be more than one per component.
+/* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+ * deployment of v0.38.0. To see the error, remove this comment and run flow */
 export type Fiber = Instance & {
 
   // The Fiber to return to after finishing processing this one.

Libraries/Renderer/src/renderers/shared/fiber/ReactFiberCompleteWork.js

@@ -79,7 +79,6 @@ module.exports = function<T, P, I, C>(config : HostConfig<T, P, I, C>) {
         item = item.sibling;
       } while (item);
     } else {
-      // $FlowFixMe: Refinement issue. If it is not a Fiber or null, it is a yield
       yields.push(output);
     }
   }

Libraries/Renderer/src/renderers/shared/fiber/ReactReifiedYield.js

@@ -24,6 +24,9 @@ exports.createReifiedYield = function(yieldNode : ReactYield) : ReifiedYield {
     yieldNode.continuation,
     yieldNode.key
   );
+  /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+   * deployment of v0.38.0. To see the error, remove this comment and run flow
+   */
   return {
     continuation: fiber,
     props: yieldNode.props,

Libraries/Renderer/src/renderers/shared/fiber/isomorphic/ReactCoroutine.js

@@ -33,9 +33,6 @@ export type ReactCoroutine = {
   children: any,
   // This should be a more specific CoroutineHandler
   handler: (props: any, yields: Array<ReifiedYield>) => ReactNodeList,
-  /* $FlowFixMe(>=0.31.0): Which is it? mixed? Or Object? Must match
-   * `ReactYield` type.
-   */
   props: mixed,
 };
 export type ReactYield = {

local-cli/server/middleware/heapCapture/src/AggrowTable.jsx

@@ -47,6 +47,9 @@ export default class AggrowTable extends React.Component {
   state: State;
 
   componentDidMount() {
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     document.body.addEventListener('keydown', this.keydown);
   }
 
@@ -61,6 +64,9 @@ export default class AggrowTable extends React.Component {
   }
 
   componentWillUnmount() {
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     document.body.removeEventListener('keydown', this.keydown);
   }
 

local-cli/templates/HelloWorld/_flowconfig

@@ -34,11 +34,11 @@ suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(3[0-7]\\|[1-2][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(3[0-7]\\|1[0-9]\\|[1-2][0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(3[0-8]\\|[1-2][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(3[0-8]\\|1[0-9]\\|[1-2][0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.37.0
+^0.38.0

package.json

@@ -199,7 +199,7 @@
     "eslint-plugin-babel": "^3.3.0",
     "eslint-plugin-flowtype": "^2.20.0",
     "eslint-plugin-react": "^6.4.1",
-    "flow-bin": "^0.37.0",
+    "flow-bin": "^0.38.0",
     "jest": "18.0.0",
     "jest-repl": "18.0.0",
     "jest-runtime": "18.0.0",

packager/react-packager/src/Bundler/source-map/source-map.js

@@ -59,6 +59,9 @@ function compactMapping(mapping: BabelRawMapping): RawMapping {
   }
 
   if (typeof name !== 'string') {
+    /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+     * the deployment of v0.38.0. To see the error, remove this comment and run
+     * flow */
     return ([line, column, original.line, original.column]: SourceMapping);
   }
 
@@ -77,7 +80,13 @@ function addMappingsForFile(generator, mappings, module, carryOver) {
       mapping[0] + carryOver,
       // lines start at 1, columns start at 0
       mapping[0] === 1 && mapping[1] + columnOffset || mapping[1],
+      /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+       * the deployment of v0.38.0. To see the error, remove this comment and
+       * run flow */
       mapping[2],
+      /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during
+       * the deployment of v0.38.0. To see the error, remove this comment and
+       * run flow */
       mapping[3],
       //$FlowIssue #15417846
       mapping[4],

packager/react-packager/src/ModuleGraph/worker/optimize-module.js

@@ -71,6 +71,9 @@ function optimize(transformed, file, originalCode, options): TransformResult {
 }
 
 function optimizeCode(code, map, filename, inliningOptions) {
+  /* $FlowFixMe(>=0.38.0 site=react_native_fb) - Flow error detected during the
+   * deployment of v0.38.0. To see the error, remove this comment and run flow
+   */
   return babel.transform(code, {
     plugins: [
       [constantFolding],