From a45246e354f3b4f80d7c5069b902c72d9d8dcd0f Mon Sep 17 00:00:00 2001 From: Peggy Rayzis Date: Thu, 2 Feb 2017 04:12:59 -0800 Subject: [PATCH] Fix .gitignore of HelloWorld template to commit third party JARs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Hi RN team! Thanks for all that you do. 🎉 **Motivation:** I noticed in the [Buck docs](https://buckbuild.com/article/exopackage.html) (scroll down to Step 2) that it expects third party JARs to live in version control. Currently, the HelloWorld template ignores these dependencies from version control, which is a bit confusing. Closes https://github.com/facebook/react-native/pull/11738 Differential Revision: D4494423 Pulled By: mkonicek fbshipit-source-id: 37b946ad9c30af2b47b409bae6830bba5917491a --- local-cli/templates/HelloWorld/_gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/local-cli/templates/HelloWorld/_gitignore b/local-cli/templates/HelloWorld/_gitignore index 8fce63971..10be19751 100644 --- a/local-cli/templates/HelloWorld/_gitignore +++ b/local-cli/templates/HelloWorld/_gitignore @@ -39,7 +39,6 @@ yarn-error.log # BUCK buck-out/ \.buckd/ -android/app/libs *.keystore # fastlane