status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-14 19:44:13 +00:00
Code Issues Projects Releases Wiki Activity

bottom styling isn't applied when a View is not absolute-positioned

Browse Source 
Summary: The new CSSLayout have a wrong calculate for the getRelativePosition. So use the getLeadingPosition will get 0 instead of return undefined. Fix it with using isLeadingPosDefined.

Reviewed By: fkgozali

Differential Revision: D3640799

fbshipit-source-id: 50d3bd2ea4c0d8bf96ba34297425ba269b0535cd
This commit is contained in:
Mengjue Wang 2016-07-28 23:36:20 -07:00 committed by Facebook Github Bot 4
parent 66514869aa
commit a06e4b75e4
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
React/CSSLayout/CSSLayout.c
View File

@ -700,9 +700,8 @@ static void setTrailingPosition(CSSNode* node, CSSNode* child, CSSFlexDirection
// If both left and right are defined, then use left. Otherwise return // If both left and right are defined, then use left. Otherwise return
// +left or -right depending on which is defined. // +left or -right depending on which is defined.
static float getRelativePosition(CSSNode* node, CSSFlexDirection axis) { static float getRelativePosition(CSSNode* node, CSSFlexDirection axis) {
float lead = getLeadingPosition(node, axis); if (isLeadingPosDefined(node, axis)) {
if (!isUndefined(lead)) { return getLeadingPosition(node, axis);
return lead;
} }
return -getTrailingPosition(node, axis); return -getTrailingPosition(node, axis);
} }