status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Change `polyfills` to `getPolyfills` function for more configurability 

Summary:
Changing the `polyfills` option to `getPolyfills({platform})` will let us return a different set of polyfills for each platform. See https://github.com/facebook/metro-bundler/issues/25 for the motivation.
Closes https://github.com/facebook/react-native/pull/14943

Differential Revision: D5405878

Pulled By: mjesun

fbshipit-source-id: 908e49a286841f97655603d92d0fdfb000547510
This commit is contained in:
James Ide 2017-07-12 08:06:19 -07:00 committed by Facebook Github Bot
parent 999851a389
commit 9f87728f5d
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
local-cli/server/runServer.js
View File

@ -157,7 +157,7 @@ function getPackagerServer(args, config) {
maxWorkers: args.maxWorkers, maxWorkers: args.maxWorkers,
platforms: defaultPlatforms.concat(args.platforms), platforms: defaultPlatforms.concat(args.platforms),
polyfillModuleNames: config.getPolyfillModuleNames(), polyfillModuleNames: config.getPolyfillModuleNames(),
polyfills: config.polyfills, getPolyfills: config.getPolyfills,
postMinifyProcess: config.postMinifyProcess, postMinifyProcess: config.postMinifyProcess,
postProcessModules: config.postProcessModules, postProcessModules: config.postProcessModules,
projectRoots: args.projectRoots, projectRoots: args.projectRoots,

5
local-cli/util/Config.js
View File

@ -94,7 +94,7 @@ export type ConfigT = {
* An optional list of polyfills to include in the bundle. The list defaults * An optional list of polyfills to include in the bundle. The list defaults
* to a set of common polyfills for Number, String, Array, Object... * to a set of common polyfills for Number, String, Array, Object...
*/ */
polyfills: Array<string>, getPolyfills: ({platform: string}) => Array<string>,
/** /**
* An optional function that can modify the code and source map of bundle * An optional function that can modify the code and source map of bundle
@ -177,7 +177,7 @@ const Config = {
getSourceExts: () => [], getSourceExts: () => [],
getTransformModulePath: () => require.resolve('metro-bundler/src/transformer.js'), getTransformModulePath: () => require.resolve('metro-bundler/src/transformer.js'),
getTransformOptions: async () => ({}), getTransformOptions: async () => ({}),
polyfills: [ getPolyfills: ({platform}) => [
require.resolve('../../Libraries/polyfills/Object.es6.js'), require.resolve('../../Libraries/polyfills/Object.es6.js'),
require.resolve('../../Libraries/polyfills/console.js'), require.resolve('../../Libraries/polyfills/console.js'),
require.resolve('../../Libraries/polyfills/error-guard.js'), require.resolve('../../Libraries/polyfills/error-guard.js'),
@ -239,6 +239,7 @@ const Config = {
}, },
loadFileCustom<TConfig: {}>(pathToConfig: string, defaults: TConfig): TConfig { loadFileCustom<TConfig: {}>(pathToConfig: string, defaults: TConfig): TConfig {
// $FlowFixMe: necessary dynamic require
const config: {} = require(pathToConfig); const config: {} = require(pathToConfig);
return {...defaults, ...config}; return {...defaults, ...config};
}, },