enhance RNTester android config

Summary:
* cliPath is not config right
* root config can be better config instead of a relative path which can easily go wrong if location changed
* DeveloperSupport should only be in debug mode.

* make https://github.com/facebook/react-native/pull/18732 change on local.
* config signingConfig
* execute `./gradlew :RNTester:android:app:assembleRelease`, and run app on device to check everything is fine.

none

[GENERAL][ENHANCEMENT][RNTester]
Closes https://github.com/facebook/react-native/pull/18746

Differential Revision: D7548846

Pulled By: hramos

fbshipit-source-id: 8943f84a6c99456477dff2deeaacc96f093b2e09
This commit is contained in:
gengjiawen 2018-04-08 17:13:52 -07:00 committed by Facebook Github Bot
parent 9574f88701
commit 9874004711
2 changed files with 3 additions and 2 deletions

View File

@ -58,9 +58,10 @@ import com.android.build.OutputFile
*/
project.ext.react = [
cliPath: "$rootDir/local-cli/cli.js",
bundleAssetName: "RNTesterApp.android.bundle",
entryFile: file("../../js/RNTesterApp.android.js"),
root: "../../../",
root: "$rootDir",
inputExcludes: ["android/**", "./**"]
]

View File

@ -34,7 +34,7 @@ public class RNTesterApplication extends Application implements ReactApplication
@Override
public boolean getUseDeveloperSupport() {
return true;
return BuildConfig.DEBUG;
}
@Override