status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-21 21:58:18 +00:00
Code Issues Projects Releases Wiki Activity

Avoid cleaning up ReactRootView content when reactContext is destroyed

Browse Source 
Summary: This diff avoids deleting all the views of ReactRootView when the ReactContext is destroyed (ONLY FOR FABRIC). In Fabric these views are removed and deleted by the framework when the ReactShadowNode is destroyed.

Reviewed By: shergin

Differential Revision: D10319737

fbshipit-source-id: 2e2d2599006cd8205e0153c18cd75383387ce1df
This commit is contained in:
David Vacca 2018-10-12 18:36:41 -07:00 committed by Facebook Github Bot
parent 5d414665ea
commit 9817f85def
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View File

@ -1073,7 +1073,11 @@ public class ReactInstanceManager {
synchronized (mAttachedRootViews) {
for (ReactRootView rootView : mAttachedRootViews) {
rootView.removeAllViews();
if (rootView.getUIManagerType() != FABRIC) {
// All the views created in surfaces that are managed by Fabric, are removed and deleted
// by the Mounting Layer.
rootView.removeAllViews();
}
rootView.setId(View.NO_ID);
}
}