mirror of
https://github.com/status-im/react-native.git
synced 2025-01-27 01:40:08 +00:00
Add $(inherited) to OTHER_LDFLAGS in xcodeproj template
Summary: This is particularly important when using generated xcode project together with cocoapods (or anything that leverages a custom xcconfig) If we do not set `$(inherited)`, then user will get cryptic "Symbol(s) not found for architecture ..." errors that will be really difficult to track down, especially for beginners. This happens because without setting `$(inherited)` we are essentially overriding settings provided on project level (rather than target level) as well as `.xcconfig` level. **Test plan (required)** ```bash react-native init MyProject cd ios pod init ``` Now go and add a pod to the `Podfile`, say ```ruby pod 'HockeySDK' ``` And try to use it in `AppDelegate.m` ```objc ... [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:@"APP_IDENTIFIER"]; [[BITHockeyManager sharedHockeyManager] startManager]; ``` Before this change, you'll get errors like this ![image](https://cloud.githubusercontent.com/assets/696842/15801450/feb3c036-2a4 Closes https://github.com/facebook/react-native/pull/7927 Differential Revision: D3430228 Pulled By: javache fbshipit-source-id: ef453ad2e822726db0159d24ec93e301192e21de
This commit is contained in:
parent
4c245160bd
commit
93ff5799a5
@ -615,6 +615,7 @@
|
||||
INFOPLIST_FILE = "<%= name %>/Info.plist";
|
||||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
|
||||
OTHER_LDFLAGS = (
|
||||
"$(inherited)",
|
||||
"-ObjC",
|
||||
"-lc++",
|
||||
);
|
||||
@ -634,6 +635,7 @@
|
||||
INFOPLIST_FILE = "<%= name %>/Info.plist";
|
||||
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
|
||||
OTHER_LDFLAGS = (
|
||||
"$(inherited)",
|
||||
"-ObjC",
|
||||
"-lc++",
|
||||
);
|
||||
|
Loading…
x
Reference in New Issue
Block a user