status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

SnapshotViewIOS: Remove PropTypes (#21294) 

Summary:
Part of: https://github.com/react-native-community/discussions-and-proposals/issues/29

This PR removes all PropTypes from `SnapshotViewIOS`, and fills out the flow types for its event callbacks.
Pull Request resolved: https://github.com/facebook/react-native/pull/21294

Differential Revision: D10011659

Pulled By: TheSavior

fbshipit-source-id: 28bfa0ab58c0655f9b905d3cb6530b57166c67f9
This commit is contained in:
empyrical 2018-09-24 10:55:30 -07:00 committed by Facebook Github Bot
parent e0170a9445
commit 93717e3f17
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Libraries/RCTTest/SnapshotViewIOS.ios.js
View File

@ -10,8 +10,6 @@
'use strict'; 'use strict';
const DeprecatedViewPropTypes = require('DeprecatedViewPropTypes');
const PropTypes = require('prop-types');
const React = require('React'); const React = require('React');
const StyleSheet = require('StyleSheet'); const StyleSheet = require('StyleSheet');
const UIManager = require('UIManager'); const UIManager = require('UIManager');
@ -21,6 +19,9 @@ const requireNativeComponent = require('requireNativeComponent');
const {TestModule} = require('NativeModules'); const {TestModule} = require('NativeModules');
import type {SyntheticEvent} from 'CoreEventTypes';
import type {ViewProps} from 'ViewPropTypes';
// Verify that RCTSnapshot is part of the UIManager since it is only loaded // Verify that RCTSnapshot is part of the UIManager since it is only loaded
// if you have linked against RCTTest like in tests, otherwise we will have // if you have linked against RCTTest like in tests, otherwise we will have
// a warning printed out // a warning printed out
@ -28,20 +29,20 @@ const RCTSnapshot = UIManager.RCTSnapshot
? requireNativeComponent('RCTSnapshot') ? requireNativeComponent('RCTSnapshot')
: View; : View;
class SnapshotViewIOS extends React.Component<{ type SnapshotReadyEvent = SyntheticEvent<
onSnapshotReady?: Function, $ReadOnly<{
testIdentifier?: string, testIdentifier: string,
}> { }>,
// $FlowFixMe(>=0.41.0) >;
static propTypes = {
...DeprecatedViewPropTypes,
// A callback when the Snapshot view is ready to be compared
onSnapshotReady: PropTypes.func,
// A name to identify the individual instance to the SnapshotView
testIdentifier: PropTypes.string,
};
onDefaultAction = (event: Object) => { type Props = $ReadOnly<{|
...ViewProps,
onSnapshotReady?: ?(event: SnapshotReadyEvent) => mixed,
testIdentifier?: ?string,
|}>;
class SnapshotViewIOS extends React.Component<Props> {
onDefaultAction = (event: SnapshotReadyEvent) => {
TestModule.verifySnapshot(TestModule.markTestPassed); TestModule.verifySnapshot(TestModule.markTestPassed);
}; };