status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix instructions in 'react-native init' 

Summary: This was buggy and didn't print the folder we need to cd into.

Reviewed By: mkonicek

Differential Revision:
D4313396
Ninja: OSS only

fbshipit-source-id: 0e15baf818065b63e939def60a1366e2251aac7d
This commit is contained in:
Martin Konicek 2016-12-12 09:03:38 -08:00 committed by Facebook Github Bot
parent 46f3ff68b6
commit 8c7f36021a
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
local-cli/generator/printRunInstructions.js
View File

@ -13,22 +13,19 @@ var path = require('path');
function printRunInstructions(projectDir, projectName) { function printRunInstructions(projectDir, projectName) {
const absoluteProjectDir = path.resolve(projectDir); const absoluteProjectDir = path.resolve(projectDir);
const relativeProjectDir = path.relative(process.cwd(), absoluteProjectDir);
// If we're in the project directory already, no need to 'cd' into it
const needToCd = !!relativeProjectDir;
// iOS // iOS
const xcodeProjectPath = path.resolve(projectDir, 'ios', projectName) + '.xcodeproj'; const xcodeProjectPath = path.resolve(projectDir, 'ios', projectName) + '.xcodeproj';
const relativeXcodeProjectPath = path.relative(process.cwd(), xcodeProjectPath); const relativeXcodeProjectPath = path.relative(process.cwd(), xcodeProjectPath);
console.log(chalk.white.bold('To run your app on iOS:')); console.log(chalk.white.bold('To run your app on iOS:'));
if (needToCd) { console.log(' cd ' + relativeProjectDir); } console.log(' cd ' + absoluteProjectDir);
console.log(' react-native run-ios'); console.log(' react-native run-ios');
console.log(' - or -'); console.log(' - or -');
console.log(' Open ' + relativeXcodeProjectPath + ' in Xcode'); console.log(' Open ' + relativeXcodeProjectPath + ' in Xcode');
console.log(' Hit the Run button'); console.log(' Hit the Run button');
// Android // Android
console.log(chalk.white.bold('To run your app on Android:')); console.log(chalk.white.bold('To run your app on Android:'));
console.log(' cd ' + absoluteProjectDir);
console.log(' Have an Android emulator running (quickest way to get started), or a device connected'); console.log(' Have an Android emulator running (quickest way to get started), or a device connected');
if (needToCd) { console.log(' cd ' + relativeProjectDir); }
console.log(' react-native run-android'); console.log(' react-native run-android');
} }