status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix and update Android documentation (Integrating with existing app section) 

Summary:
Android documentation was not updated accordingly following a native Android API surface modification which ended up renaming a couple of methods  (introduced in 19a1c4c229)

This PR is fixing the documentation while at the same time updating the documentation in the same section adding another method which was introduced in the same commit and which needs to be called as well (please see comment in [ReactInstanceManager.java](5b871ad9d7/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java (L44)) : `It's required to pass owning activity's lifecycle events to the instance manager [...]`)
Closes https://github.com/facebook/react-native/pull/8032

Differential Revision: D3424674

fbshipit-source-id: 867f98ef210d7e9402afc278fb7b8e08890de3f0
This commit is contained in:
Benoit Lemaire 2016-06-13 07:30:58 -07:00 committed by Facebook Github Bot 3
parent 933e17949b
commit 86ab55328b
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
docs/EmbeddedAppAndroid.md
View File

@ -83,7 +83,7 @@ protected void onPause() {
super.onPause();
if (mReactInstanceManager != null) {
mReactInstanceManager.onPause();
mReactInstanceManager.onHostPause();
}
}
@ -92,7 +92,16 @@ protected void onResume() {
super.onResume();
if (mReactInstanceManager != null) {
mReactInstanceManager.onResume(this, this);
mReactInstanceManager.onHostResume(this, this);
}
}
@Override
protected void onDestroy() {
super.onDestroy();
if (mReactInstanceManager != null) {
mReactInstanceManager.onHostDestroy();
}
}
```