status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed retain cycle in RCTFBHTTPRequestHandler 

Summary: Following common ObjC pattern, we have to store delegates as weak pointers.

Reviewed By: mmmulani

Differential Revision: D6558886

fbshipit-source-id: 11a710a7e9e17d7c6a78ae46b53b043f44ccf8e5
This commit is contained in:
Valentin Shergin 2017-12-13 15:46:11 -08:00 committed by Facebook Github Bot
parent 71751e9cc7
commit 85503a0612
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
React/Base/RCTURLRequestHandler.h
View File

@ -29,6 +29,7 @@
* itself. This will be used later to refer to the request in callbacks. The * itself. This will be used later to refer to the request in callbacks. The
* `sendRequest:withDelegate:` method *must* return before calling any of the * `sendRequest:withDelegate:` method *must* return before calling any of the
* delegate methods, or the delegate won't recognize the token. * delegate methods, or the delegate won't recognize the token.
* Following common Objective-C pattern, `delegate` will not be retained.
*/ */
- (id)sendRequest:(NSURLRequest *)request - (id)sendRequest:(NSURLRequest *)request
withDelegate:(id<RCTURLRequestDelegate>)delegate; withDelegate:(id<RCTURLRequestDelegate>)delegate;