status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Loosen Platform check to allow better code sharing for out-of-tree platforms 

Summary:
Don't lock out other non-iOS platforms (e.g. Windows) with an overly
specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking.

Tested Android and iOS playground on simulators.

 [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms.
Closes https://github.com/facebook/react-native/pull/18308

Differential Revision: D7230803

Pulled By: hramos

fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
This commit is contained in:
Matt Hargett 2018-03-12 08:40:14 -07:00 committed by Facebook Github Bot
parent 19dd9a2ce6
commit 84affbd6a3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/ReactNative/UIManager.js
View File

@ -77,7 +77,7 @@ if (Platform.OS === 'ios') {
}); });
} }
}); });
} else if (Platform.OS === 'android' && UIManager.ViewManagerNames) { } else if (UIManager.ViewManagerNames) {
UIManager.ViewManagerNames.forEach(viewManagerName => { UIManager.ViewManagerNames.forEach(viewManagerName => {
defineLazyObjectProperty(UIManager, viewManagerName, { defineLazyObjectProperty(UIManager, viewManagerName, {
get: () => UIManager.getConstantsForViewManager(viewManagerName), get: () => UIManager.getConstantsForViewManager(viewManagerName),