status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add Random Access Module file names to stack traces 

Summary: Adds support to generate stack traces that can be used with source maps that have a `x_facebook_offsets` field. If a file name of a stack frame contains only digits and ends with “.js”, it is included in the trace format generated by `ExceptionsManagerModule`

Reviewed By: martinbigio

Differential Revision: D3072953

fb-gh-sync-id: 69a57e3e2c758034939e5264008871f38f48a78f
shipit-source-id: 69a57e3e2c758034939e5264008871f38f48a78f
This commit is contained in:
David Aurelio 2016-03-22 15:21:26 -07:00 committed by Facebook Github Bot 3
parent 78ad15d85b
commit 83fb122406
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ReactAndroid/src/main/java/com/facebook/react/modules/core/ExceptionsManagerModule.java
View File

@ -9,7 +9,8 @@
package com.facebook.react.modules.core; package com.facebook.react.modules.core;
import java.io.File; import java.util.regex.Matcher;
import java.util.regex.Pattern;
import com.facebook.common.logging.FLog; import com.facebook.common.logging.FLog;
import com.facebook.react.bridge.BaseJavaModule; import com.facebook.react.bridge.BaseJavaModule;
@ -22,6 +23,7 @@ import com.facebook.react.common.ReactConstants;
public class ExceptionsManagerModule extends BaseJavaModule { public class ExceptionsManagerModule extends BaseJavaModule {
static private final Pattern mJsModuleIdPattern = Pattern.compile("(?:^|[/\\\\])(\\d+\\.js)$");
private final DevSupportManager mDevSupportManager; private final DevSupportManager mDevSupportManager;
public ExceptionsManagerModule(DevSupportManager devSupportManager) { public ExceptionsManagerModule(DevSupportManager devSupportManager) {
@ -33,6 +35,23 @@ public class ExceptionsManagerModule extends BaseJavaModule {
return "RKExceptionsManager"; return "RKExceptionsManager";
} }
// If the file name of a stack frame is numeric (+ ".js"), we assume it's a lazily injected module
// coming from a "random access bundle". We are using special source maps for these bundles, so
// that we can symbolicate stack traces for multiple injected files with a single source map.
// We have to include the module id in the stack for that, though. The ".js" suffix is kept to
// avoid ambiguities between "module-id:line" and "line:column".
static private String stackFrameToModuleId(ReadableMap frame) {
if (frame.hasKey("file") &&
!frame.isNull("file") &&
frame.getType("file") == ReadableType.String) {
final Matcher matcher = mJsModuleIdPattern.matcher(frame.getString("file"));
if (matcher.find()) {
return matcher.group(1) + ":";
}
}
return "";
}
private String stackTraceToString(String message, ReadableArray stack) { private String stackTraceToString(String message, ReadableArray stack) {
StringBuilder stringBuilder = new StringBuilder(message).append(", stack:\n"); StringBuilder stringBuilder = new StringBuilder(message).append(", stack:\n");
for (int i = 0; i < stack.size(); i++) { for (int i = 0; i < stack.size(); i++) {
@ -40,6 +59,7 @@ public class ExceptionsManagerModule extends BaseJavaModule {
stringBuilder stringBuilder
.append(frame.getString("methodName")) .append(frame.getString("methodName"))
.append("@") .append("@")
.append(stackFrameToModuleId(frame))
.append(frame.getInt("lineNumber")); .append(frame.getInt("lineNumber"));
if (frame.hasKey("column") && if (frame.hasKey("column") &&
!frame.isNull("column") && !frame.isNull("column") &&