status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-22 06:08:24 +00:00
Code Issues Projects Releases Wiki Activity

Stop mounting of Views when there is an exception in Native

Browse Source 
Summary: This diff fixes exception handling for Mounting of views, as soon as there is an exception we stop the mounting of views because from that point the UI View tree is going to be inconsistent with the ReactShadow tree from C++. We also stop the mounting of views when the host is paused, this allows us to not keep mounting views

Reviewed By: shergin

Differential Revision: D10510334

fbshipit-source-id: b0d3eba580ff92d8b8400244ec9d7c266db42ff9
This commit is contained in:
David Vacca 2018-11-08 16:55:11 -08:00 committed by Facebook Github Bot
parent 81b74ec1ed
commit 8329c10932
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java
View File

@ -1085,11 +1085,7 @@ public class ReactInstanceManager {
synchronized (mAttachedRootViews) {
for (ReactRootView rootView : mAttachedRootViews) {
if (rootView.getUIManagerType() != FABRIC) {
// All the views created in surfaces that are managed by Fabric, are removed and deleted
// by the Mounting Layer.
rootView.removeAllViews();
}
rootView.removeAllViews();
rootView.setId(View.NO_ID);
}
}