From 82bd4337c9b3c58fc8c2cad5f32a0b8908a3bc07 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 16 Apr 2018 07:43:25 -0700 Subject: [PATCH] Fabric: Fixed ComponentDescriptorTest Summary: Trivial. Reviewed By: mdvacca Differential Revision: D7591712 fbshipit-source-id: fbcaaa30004f096749a6bcd47dcc56c060d7524a --- ReactCommon/fabric/core/tests/ComponentDescriptorTest.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ReactCommon/fabric/core/tests/ComponentDescriptorTest.cpp b/ReactCommon/fabric/core/tests/ComponentDescriptorTest.cpp index 5c2a0bc9d..460a3124b 100644 --- a/ReactCommon/fabric/core/tests/ComponentDescriptorTest.cpp +++ b/ReactCommon/fabric/core/tests/ComponentDescriptorTest.cpp @@ -26,9 +26,7 @@ TEST(ComponentDescriptorTest, createShadowNode) { ASSERT_STREQ(node->getComponentName().c_str(), "Test"); ASSERT_EQ(node->getTag(), 9); ASSERT_EQ(node->getRootTag(), 1); - - // TODO(#27369757): getProps() doesn't work - // ASSERT_STREQ(node->getProps()->getNativeId().c_str(), "testNativeID"); + ASSERT_STREQ(node->getProps()->getNativeId().c_str(), "abc"); } TEST(ComponentDescriptorTest, cloneShadowNode) { @@ -44,9 +42,7 @@ TEST(ComponentDescriptorTest, cloneShadowNode) { ASSERT_STREQ(cloned->getComponentName().c_str(), "Test"); ASSERT_EQ(cloned->getTag(), 9); ASSERT_EQ(cloned->getRootTag(), 1); - - // TODO(#27369757): getProps() doesn't work - // ASSERT_STREQ(cloned->getProps()->getNativeId().c_str(), "testNativeID"); + ASSERT_STREQ(cloned->getProps()->getNativeId().c_str(), "abc"); } TEST(ComponentDescriptorTest, appendChild) {