Remove script argument to proxy loadApplicationScript
Summary: The JSCExecutor API gets passed script data and a URL, but the proxy's purpose in life is to load from the network, so the script data is useless. The code was failing to handle null script data, so rather than just passing nullptr all the time, I removed the argument. if there's a use case in the future for it, we can put it back. Reviewed By: steveluscher Differential Revision: D3312467 fbshipit-source-id: 986c48f1ef3c24e6b5569046ccb08d7864cdcd3d
This commit is contained in:
parent
0694a2991c
commit
8199893574
|
@ -36,11 +36,10 @@ public interface JavaJSExecutor {
|
|||
|
||||
/**
|
||||
* Load javascript into the js context
|
||||
* @param script script contet to be executed
|
||||
* @param sourceURL url or file location from which script content was loaded
|
||||
*/
|
||||
@DoNotStrip
|
||||
void loadApplicationScript(String script, String sourceURL) throws ProxyExecutorException;
|
||||
void loadApplicationScript(String sourceURL) throws ProxyExecutorException;
|
||||
|
||||
/**
|
||||
* Execute javascript method within js context
|
||||
|
|
|
@ -159,7 +159,7 @@ public class WebsocketJavaScriptExecutor implements JavaJSExecutor {
|
|||
}
|
||||
|
||||
@Override
|
||||
public void loadApplicationScript(String script, String sourceURL)
|
||||
public void loadApplicationScript(String sourceURL)
|
||||
throws ProxyExecutorException {
|
||||
JSExecutorCallbackFuture callback = new JSExecutorCallbackFuture();
|
||||
Assertions.assertNotNull(mWebSocketClient).loadApplicationScript(
|
||||
|
|
Loading…
Reference in New Issue